Re: [PATCH] trivial - constify sched.h

2007-08-31 Thread Matthew Wilcox
On Fri, Aug 31, 2007 at 02:53:23PM +0100, Christoph Hellwig wrote: > On Thu, Aug 30, 2007 at 10:55:49PM +0200, Jan Engelhardt wrote: > > "those callers". There was _exactly one_ caller, and that was an out-of-tree > > module. There were not any in-kernel callers before, and it did not generate > >

Re: [PATCH] trivial - constify sched.h

2007-08-31 Thread Christoph Hellwig
On Thu, Aug 30, 2007 at 10:55:49PM +0200, Jan Engelhardt wrote: > "those callers". There was _exactly one_ caller, and that was an out-of-tree > module. There were not any in-kernel callers before, and it did not generate > any warning. That is perhaps why no one had constified it before me. This d

Re: [PATCH] trivial - constify sched.h

2007-08-30 Thread Satyam Sharma
On Thu, 30 Aug 2007, Jan Engelhardt wrote: > > On Aug 31 2007 02:11, Satyam Sharma wrote: > >> So that you can actually pass in a const struct task_struct * without > >> having > >> to cast it back to [non-const]. > > > >... which makes zero sense, because ... > > > >> Why one would have a cons

Re: [PATCH] trivial - constify sched.h

2007-08-30 Thread Jan Engelhardt
On Aug 31 2007 02:11, Satyam Sharma wrote: >> So that you can actually pass in a const struct task_struct * without having >> to cast it back to [non-const]. > >... which makes zero sense, because ... > >> Why one would have a const struct task_struct * in the first place >> is a different matter.

Re: [PATCH] trivial - constify sched.h

2007-08-30 Thread Satyam Sharma
On Thu, 30 Aug 2007, Jan Engelhardt wrote: > > On Aug 28 2007 01:33, Alexey Dobriyan wrote: > > > >On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote: > >> Add const to some struct task_struct * uses > > > >Why, oh, why? > > > So that you can actually pass in a const struct task_struc

Re: [PATCH] trivial - constify sched.h

2007-08-30 Thread Jan Engelhardt
On Aug 28 2007 01:33, Alexey Dobriyan wrote: > >On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote: >> Add const to some struct task_struct * uses > >Why, oh, why? So that you can actually pass in a const struct task_struct * without having to cast it back to [non-const]. Why one would

Re: [PATCH] trivial - constify sched.h

2007-08-27 Thread Alexey Dobriyan
On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote: > Add const to some struct task_struct * uses Why, oh, why? This way code there are more characters on screen and zero change in vmlinux, at least here. > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1222,22 +1222,22

Re: [PATCH] trivial - constify sched.h

2007-08-27 Thread Jiri Slaby
Joe Perches napsal(a): > Add const to some struct task_struct * uses Does this have any impact on generated code? What (some objdumps or something)? Or more descriptive log, why is this about to be done, please. > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > --- > > include/linux/sche

[PATCH] trivial - constify sched.h

2007-08-27 Thread Joe Perches
Add const to some struct task_struct * uses Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/sched.h | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index ba78807..71d40a1 100644 ---