Re: [PATCH] tracing: make ftrace_print_array_seq compute buf_len

2015-04-28 Thread Alex Bennée
Steven Rostedt writes: > On Mon, 27 Apr 2015 15:22:02 +0100 > Dave P Martin wrote: > >> On Mon, Apr 27, 2015 at 01:17:48PM +0100, Alex Bennée wrote: >> > The only caller to this function was getting it wrong. I favoured >> >> What caller? >> >> Wrong in what way? > > Yes, please add that info

Re: [PATCH] tracing: make ftrace_print_array_seq compute buf_len

2015-04-27 Thread Steven Rostedt
On Mon, 27 Apr 2015 15:22:02 +0100 Dave P Martin wrote: > On Mon, Apr 27, 2015 at 01:17:48PM +0100, Alex Bennée wrote: > > The only caller to this function was getting it wrong. I favoured > > What caller? > > Wrong in what way? Yes, please add that info to the change log. > > > pushing the

Re: [PATCH] tracing: make ftrace_print_array_seq compute buf_len

2015-04-27 Thread Dave P Martin
On Mon, Apr 27, 2015 at 01:17:48PM +0100, Alex Bennée wrote: > The only caller to this function was getting it wrong. I favoured What caller? Wrong in what way? > pushing the calculation to as close to the need as possible rather than > fixing the one caller. This seems reasonable, but... > >

[PATCH] tracing: make ftrace_print_array_seq compute buf_len

2015-04-27 Thread Alex Bennée
The only caller to this function was getting it wrong. I favoured pushing the calculation to as close to the need as possible rather than fixing the one caller. Signed-off-by: Alex Bennée --- include/linux/ftrace_event.h | 2 +- kernel/trace/trace_output.c | 3 ++- 2 files changed, 3 insertions