On Fri, 2013-08-02 at 21:21 -0400, Steven Rostedt wrote:
> That means that we don't even need the setall in tracing_open_pipe.
> Technically, would shouldn't even allocate it, but for now we should,
> just to be safe.
Your patch is fine as it is. I'll do the other cleanups for 3.12.
Thanks!
-- S
On Fri, 2013-08-02 at 21:16 +0400, Andrew Vagin wrote:
> tracing_read_pipe zeros all fields bellow "seq". The declaration contains
> a comment about that, but it doesn't help.
>
> The first field is "snapshot", it's true when current open file is
> snapshot. Looks obvious, that it should not be ze
On Fri, 2013-08-02 at 11:15 -0700, David Sharp wrote:
> Wow. That is a terrible hack. Thanks for noticing it.
Why thank you :-)
It's a hack from doing things that way else where and long ago.
>
> If I may suggest a way better idea: put these zeroed-in-pipe_read
> members in an embedded anonymo
On Fri, Aug 2, 2013 at 10:16 AM, Andrew Vagin wrote:
> tracing_read_pipe zeros all fields bellow "seq". The declaration contains
> a comment about that, but it doesn't help.
>
> The first field is "snapshot", it's true when current open file is
> snapshot. Looks obvious, that it should not be zero
tracing_read_pipe zeros all fields bellow "seq". The declaration contains
a comment about that, but it doesn't help.
The first field is "snapshot", it's true when current open file is
snapshot. Looks obvious, that it should not be zeroed.
The second field is "started". It was converted from cpuma
5 matches
Mail list logo
