Re: [PATCH] tracing: Fix file mode of free_buffer

2013-05-28 Thread Steven Rostedt
On Tue, 2013-05-28 at 13:14 -0700, David Sharp wrote: > On Tue, May 28, 2013 at 12:34 PM, Vaibhav Nagarnaik > wrote: > > On Sun, May 26, 2013 at 1:52 AM, Wang YanQing wrote: > >> Commit 4f271a2a60c748599b30bb4dafff30d770439b96 > >> (tracing: Add a proc file to stop tracing and free buffer) > >> i

Re: [PATCH] tracing: Fix file mode of free_buffer

2013-05-28 Thread David Sharp
On Tue, May 28, 2013 at 12:34 PM, Vaibhav Nagarnaik wrote: > On Sun, May 26, 2013 at 1:52 AM, Wang YanQing wrote: >> Commit 4f271a2a60c748599b30bb4dafff30d770439b96 >> (tracing: Add a proc file to stop tracing and free buffer) >> implement a method to free up ring buffer in kernel memory >> in th

Re: [PATCH] tracing: Fix file mode of free_buffer

2013-05-28 Thread Vaibhav Nagarnaik
On Sun, May 26, 2013 at 1:52 AM, Wang YanQing wrote: > Commit 4f271a2a60c748599b30bb4dafff30d770439b96 > (tracing: Add a proc file to stop tracing and free buffer) > implement a method to free up ring buffer in kernel memory > in the release code path of free_buffer's fd. > > Then we don't need re

Re: [PATCH] tracing: Fix file mode of free_buffer

2013-05-28 Thread Steven Rostedt
David, Vaibhav, Any comments on this patch? -- Steve On Sun, 2013-05-26 at 16:52 +0800, Wang YanQing wrote: > Commit 4f271a2a60c748599b30bb4dafff30d770439b96 > (tracing: Add a proc file to stop tracing and free buffer) > implement a method to free up ring buffer in kernel memory > in the releas

[PATCH] tracing: Fix file mode of free_buffer

2013-05-26 Thread Wang YanQing
Commit 4f271a2a60c748599b30bb4dafff30d770439b96 (tracing: Add a proc file to stop tracing and free buffer) implement a method to free up ring buffer in kernel memory in the release code path of free_buffer's fd. Then we don't need read/write support for free_buffer, indeed we just have a dummy wri