Steven Rostedt wrote on 04/24/15 16:24:
On Mon, 20 Apr 2015 16:38:11 -0500
Ron Rechenmacher wrote:
If symbols are not exported, modules can no longer register additional
(module specified) tracepoints like they use to be able to (i.e linux-3.15.x).
Somewhere on or about commit de7b2973903c6cc5
- Original Message -
> On Mon, 20 Apr 2015 16:38:11 -0500
> Ron Rechenmacher wrote:
>
> > If symbols are not exported, modules can no longer register additional
> > (module specified) tracepoints like they use to be able to (i.e
> > linux-3.15.x).
> > Somewhere on or about commit de7b2973
On Mon, 20 Apr 2015 16:38:11 -0500
Ron Rechenmacher wrote:
> If symbols are not exported, modules can no longer register additional
> (module specified) tracepoints like they use to be able to (i.e linux-3.15.x).
> Somewhere on or about commit de7b2973903c6cc50b31ee5682a69b2219b9919d
> (Author: M
On Thu, 2015-04-23 at 16:28 +0100, Pawel Moll wrote:
> On Wed, 2015-04-22 at 16:36 +0100, David Ahern wrote:
> > On 4/22/15 8:47 AM, Arnaldo Carvalho de Melo wrote:
> > > Em Wed, Apr 22, 2015 at 08:53:14AM -0400, Steven Rostedt escreveu:
> > >> >On Tue, 21 Apr 2015 21:24:51 -0500
> > >> >Ron Rechen
On Wed, 2015-04-22 at 16:36 +0100, David Ahern wrote:
> On 4/22/15 8:47 AM, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Apr 22, 2015 at 08:53:14AM -0400, Steven Rostedt escreveu:
> >> >On Tue, 21 Apr 2015 21:24:51 -0500
> >> >Ron Rechenmacher wrote:
> >>> > >I've looked at the above reference brie
On Wed, 22 Apr 2015 11:35:41 -0500
Ron Rechenmacher wrote:
> With the understanding, as has been mentioned before, that "only the user
> space ABI is
> what we keep stable" and that before commit de7b2973903c (tracepoint: Use
> struct pointer
> instead of name hash for reg/unreg tracepoints)
Thanks, Steve :)
I was working on a reply to your previous email but I'll reply here.
I'm happy with how this is going and I'm really appreciative of how
you have/are handling (managing) this. Thanks!
Assuming I'm only getting the tip of the ice berg of "normal Linux kernel
development," I don't
On Wed, 22 Apr 2015 09:36:20 -0600
David Ahern wrote:
> One of the key requirements is a common time basis (e.g.,
> CLOCK_MONOTONIC or PERF_CLOCK) to be able to merge the events properly.
> I have a kernel module that exports perf_clock to userspace via
> clock_gettime; the 4.1 kernel should h
On 4/22/15 8:47 AM, Arnaldo Carvalho de Melo wrote:
Em Wed, Apr 22, 2015 at 08:53:14AM -0400, Steven Rostedt escreveu:
>On Tue, 21 Apr 2015 21:24:51 -0500
>Ron Rechenmacher wrote:
> >I've looked at the above reference briefly and it appears that user-space
> >would be mmapping the buffer read-
Em Wed, Apr 22, 2015 at 08:53:14AM -0400, Steven Rostedt escreveu:
> On Tue, 21 Apr 2015 21:24:51 -0500
> Ron Rechenmacher wrote:
> > I've looked at the above reference briefly and it appears that user-space
> > would be mmapping the buffer read-only. Is that correct?
>
> Correct, but I'm sure we
On Wed, 22 Apr 2015 08:53:14 -0400
Steven Rostedt wrote:
> >
> > I'd rather not get into the "you should stop doing your thing and just/only
> > do
> > something else" mode, if you don't mind. As I've said before, I believe my
> > TRACEing
> > is just the right level of complexity for the tot
On Tue, 21 Apr 2015 21:24:51 -0500
Ron Rechenmacher wrote:
> I've looked at the above reference briefly and it appears that user-space
> would be mmapping the buffer read-only. Is that correct?
Correct, but I'm sure we could still add something (if it doesn't
already exist) to have userspace wr
Steven Rostedt wrote on 04/21/15 17:44:
[ Added a bunch of people that use perf ;-) ]
Thanks. I hope they can help me get the patch accepted.
[snip]
+/*
+ * Allow modules to register additional trace routines
+ */
+EXPORT_TRACEPOINT_SYMBOL_GPL(irq_handler_entry);
+EXPORT_TRACEPOINT_SYMBOL_
[ Added a bunch of people that use perf ;-) ]
On Tue, 21 Apr 2015 17:23:45 -0500
Ron Rechenmacher wrote:
>
> Steven Rostedt wrote on 04/21/15 10:49:
> [snip]
> >
> > OK, lets see what you are doing in your patch:
>
> Thanks for helping/discussing!
>
> >
> > +/*
> > + * Allow modules to regis
Steven Rostedt wrote on 04/21/15 10:49:
[snip]
OK, lets see what you are doing in your patch:
Thanks for helping/discussing!
+/*
+ * Allow modules to register additional trace routines
+ */
+EXPORT_TRACEPOINT_SYMBOL_GPL(irq_handler_entry);
+EXPORT_TRACEPOINT_SYMBOL_GPL(irq_handler_exit);
+
On Tue, 21 Apr 2015 10:00:25 -0500
Ron Rechenmacher wrote:
> Thanks for looking at the code and providing the feedback.
>
> Using EXPORT_SYMBOL was a mistake. I just changed them to EXPORT_SYMBOL_GPL.
> I've been doing this sort of "tracing" (which I consider the "minimum level of
> complexity"
Thanks for looking at the code and providing the feedback.
Using EXPORT_SYMBOL was a mistake. I just changed them to EXPORT_SYMBOL_GPL.
I've been doing this sort of "tracing" (which I consider the "minimum level of
complexity" tracing) for about 30 years. I've never made any money on this, nor
d
On Tue, 21 Apr 2015 08:26:26 -0500
Ron Rechenmacher wrote:
> But why export anything _GPL in the first place?
>
To make it clear that they are derivatives of the kernel. An export is
just to allow modules access to the functions, they were not added for
out of tree modules. Out of tree modules
On Tue, 21 Apr 2015 07:19:30 -0500
Ron Rechenmacher wrote:
> I see in the reference I mentioned below (https://patches.linaro.org/28821/),
> and in the current mm source, that some tracepoint symbols are already
> EXPORTed,
> but not _GPL. I do not know the fine points between "GPL-ed" and "non-
But why export anything _GPL in the first place?
Christoph Hellwig wrote on 04/21/15 08:23:
On Tue, Apr 21, 2015 at 08:13:24AM -0500, Ron Rechenmacher wrote:
Hi Christoph,
My module, and information about it, can be found at:
https://cdcvs.fnal.gov/redmine/projects/trace
https://cdcvs.fnal.go
On Tue, 21 Apr 2015 06:23:55 -0700
Christoph Hellwig wrote:
> >
> > It seems that you are the person that I have to convince in order to get
> > my patch accepted. Is this true?
>
> In the end you'll need to convince a maintainer to apply it.
But a Nack from you will keep us from applying it ;
On Tue, Apr 21, 2015 at 08:13:24AM -0500, Ron Rechenmacher wrote:
> Hi Christoph,
>
> My module, and information about it, can be found at:
> https://cdcvs.fnal.gov/redmine/projects/trace
> https://cdcvs.fnal.gov/redmine/projects/trace/repository/show/src_module
> with the header at
> https://cdcv
Hi Christoph,
My module, and information about it, can be found at:
https://cdcvs.fnal.gov/redmine/projects/trace
https://cdcvs.fnal.gov/redmine/projects/trace/repository/show/src_module
with the header at
https://cdcvs.fnal.gov/redmine/projects/trace/repository/raw/include/trace.h
It seems that
I see in the reference I mentioned below (https://patches.linaro.org/28821/),
and in the current mm source, that some tracepoint symbols are already EXPORTed,
but not _GPL. I do not know the fine points between "GPL-ed" and "non-GPL-ed"
symbol
exporting. Would it make a difference if my patch pr
Hi Ron,
the Linux kernel is not a shared library, but an integrated project
that happens to be split into loadable modules.
Please send your module that uses the tracepoints and we can start
discussing if it makes sense to exports the symbols for it, or if
we can implement it in a better way.
--
Christoph Hellwig wrote on 04/21/15 01:10:
Which (in-tree) module fails with this? I don't think anyone should
actually register a symbol.
I see you (Christoph Hellwig) have asked this question in a similar context
(see https://patches.linaro.org/28821/).
This question does not seem to mak
On Mon, Apr 20, 2015 at 04:38:11PM -0500, Ron Rechenmacher wrote:
> If symbols are not exported, modules can no longer register additional
> (module specified) tracepoints like they use to be able to (i.e linux-3.15.x).
> Somewhere on or about commit de7b2973903c6cc50b31ee5682a69b2219b9919d
> (Auth
If symbols are not exported, modules can no longer register additional
(module specified) tracepoints like they use to be able to (i.e linux-3.15.x).
Somewhere on or about commit de7b2973903c6cc50b31ee5682a69b2219b9919d
(Author: Mathieu Desnoyers
Date: Tue Apr 8 17:26:21 2014 -0400
tracepoint:
28 matches
Mail list logo
