On Sat, 28 Sep 2019 01:17:48 -0700
Masami Hiramatsu wrote:
> If we found that 2 probes have different number of argument should not be
> folded at all.
> Also, we have to adjust error log position. Attached patch will fix those
> errors correctly as bellow.
Oops, missed the fixed tag. Anyway I'l
Hi Sriker and Steve,
Sorry for later, I was in a conference.
On Fri, 27 Sep 2019 19:08:53 +0530
Srikar Dronamraju wrote:
>
>
> > The cause was that the args array to compare between two probe events only
> > looked at one of the probe events size. If the other one had a smaller
> > number of
> >
> > This has a side-effect where the newer probe has same argument commands, we
> > still end up appending the probe.
>
> ??
>
> How so?
>
> If the two have the same number of arguments we do exactly what we did
> before this patch. Please explain to me how that side effect would happen?
>
On Fri, 27 Sep 2019 19:08:53 +0530
Srikar Dronamraju wrote:
\> > ---
> > kernel/trace/trace_kprobe.c | 2 ++
> > kernel/trace/trace_uprobe.c | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> > index 402dc3ce88d3..d2543a4
> The cause was that the args array to compare between two probe events only
> looked at one of the probe events size. If the other one had a smaller
> number of args, it would read out of bounds memory.
>
I thought trace_probe_compare_arg_type() should have caught this. But looks
like there is
From: "Steven Rostedt (VMware)"
Testing triggered:
==
BUG: KASAN: slab-out-of-bounds in trace_kprobe_create+0xa9e/0xe40
Read of size 8 at addr 8880c4f25a48 by task ftracetest/4798
CPU: 2 PID: 4798 Comm: ftracetest Not tain
6 matches
Mail list logo
