Re: [PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency

2018-02-12 Thread Du, Changbin
Thanks, I will improve this change in v2. And also update related docs. On Mon, Feb 12, 2018 at 12:04:52PM -0500, Steven Rostedt wrote: > On Sun, 11 Feb 2018 18:50:04 +0800 > "Du, Changbin" wrote: > > > Steve, How abount DEFINE_EVENT_PRINT as below? > > Yes, DEFINE_EVENT_PRINT is better. > > >

Re: [PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency

2018-02-12 Thread Steven Rostedt
On Sun, 11 Feb 2018 18:50:04 +0800 "Du, Changbin" wrote: > Steve, How abount DEFINE_EVENT_PRINT as below? Yes, DEFINE_EVENT_PRINT is better. > > diff --git a/include/trace/events/power.h b/include/trace/events/power.h > index 908977d..e71ce98 100644 > --- a/include/trace/events/power.h > +++ b

Re: [PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency

2018-02-12 Thread kbuild test robot
Hi Changbin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/perf/core] [also build test WARNING on v4.16-rc1 next-20180212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency

2018-02-12 Thread kbuild test robot
Hi Changbin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/perf/core] [also build test WARNING on v4.16-rc1 next-20180212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency

2018-02-11 Thread Du, Changbin
On Fri, Feb 09, 2018 at 09:44:58PM -0500, Steven Rostedt wrote: > On Sat, 10 Feb 2018 09:37:04 +0800 > changbin...@intel.com wrote: > > > From: Changbin Du > > > > The type of state is signed int, convert it to unsigned int looks weird. > > (-1 become 4294967295) > >932.123 power:cpu_idle:st

Re: [PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency

2018-02-09 Thread Steven Rostedt
On Sat, 10 Feb 2018 09:37:04 +0800 changbin...@intel.com wrote: > From: Changbin Du > > The type of state is signed int, convert it to unsigned int looks weird. > (-1 become 4294967295) >932.123 power:cpu_idle:state=1 cpu_id=0) >932.125 power:cpu_idle:state=4294967295 cpu_id=0) >932.

[PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency

2018-02-09 Thread changbin . du
From: Changbin Du The type of state is signed int, convert it to unsigned int looks weird. (-1 become 4294967295) 932.123 power:cpu_idle:state=1 cpu_id=0) 932.125 power:cpu_idle:state=4294967295 cpu_id=0) 932.132 power:cpu_idle:state=1 cpu_id=0) 932.133 power:cpu_idle:state=4294967295