Re: [PATCH] tracing/fgraph: remove unnecessary unlikely()

2018-11-04 Thread Frank Lee
Sorry for this place, I should consider this situation. -- Yangtao On Sun, Nov 4, 2018 at 10:06 PM Steven Rostedt wrote: > > On Sat, 3 Nov 2018 22:35:37 -0400 > Yangtao Li wrote: > > > WARN_ON() already contains an unlikely(), so it's not necessary to use > > unlikely. > > NACK... see below. >

Re: [PATCH] tracing/fgraph: remove unnecessary unlikely()

2018-11-04 Thread Steven Rostedt
On Sat, 3 Nov 2018 22:35:37 -0400 Yangtao Li wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to use > unlikely. NACK... see below. > > Signed-off-by: Yangtao Li > --- > kernel/trace/trace_functions_graph.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-

[PATCH] tracing/fgraph: remove unnecessary unlikely()

2018-11-03 Thread Yangtao Li
WARN_ON() already contains an unlikely(), so it's not necessary to use unlikely. Signed-off-by: Yangtao Li --- kernel/trace/trace_functions_graph.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph