Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-12-02 Thread Jarkko Sakkinen
On Sun, Nov 29, 2020 at 12:34:34PM +0100, Hans de Goede wrote: > Hi All, > > On 11/29/20 4:23 AM, Jarkko Sakkinen wrote: > > On Tue, Nov 24, 2020 at 10:45:01PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 11/24/20 6:52 PM, Jerry Snitselaar wrote: > >>> > >>> Jarkko Sakkinen @ 2020-11-23 20:26

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-29 Thread Hans de Goede
Hi All, On 11/29/20 4:23 AM, Jarkko Sakkinen wrote: > On Tue, Nov 24, 2020 at 10:45:01PM +0100, Hans de Goede wrote: >> Hi, >> >> On 11/24/20 6:52 PM, Jerry Snitselaar wrote: >>> >>> Jarkko Sakkinen @ 2020-11-23 20:26 MST: >>> On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote:

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-28 Thread Jarkko Sakkinen
On Tue, Nov 24, 2020 at 10:45:01PM +0100, Hans de Goede wrote: > Hi, > > On 11/24/20 6:52 PM, Jerry Snitselaar wrote: > > > > Jarkko Sakkinen @ 2020-11-23 20:26 MST: > > > >> On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote: > >>> > >>> Matthew Garrett @ 2020-10-15 15:39 MST: > >

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-28 Thread Jarkko Sakkinen
On Tue, Nov 24, 2020 at 10:10:21AM -0800, James Bottomley wrote: > On Tue, 2020-11-24 at 10:52 -0700, Jerry Snitselaar wrote: > > Before diving further into that though, does anyone else have an > > opinion on ripping out the irq code, and just using polling? We've > > been only polling since 2015

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-28 Thread Jarkko Sakkinen
On Tue, Nov 24, 2020 at 10:52:56AM -0700, Jerry Snitselaar wrote: > > Jarkko Sakkinen @ 2020-11-23 20:26 MST: > > > On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote: > >> > >> Matthew Garrett @ 2020-10-15 15:39 MST: > >> > >> > On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-24 Thread Hans de Goede
Hi, On 11/24/20 6:52 PM, Jerry Snitselaar wrote: > > Jarkko Sakkinen @ 2020-11-23 20:26 MST: > >> On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote: >>> >>> Matthew Garrett @ 2020-10-15 15:39 MST: >>> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote: > >

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-24 Thread James Bottomley
On Tue, 2020-11-24 at 10:52 -0700, Jerry Snitselaar wrote: > Before diving further into that though, does anyone else have an > opinion on ripping out the irq code, and just using polling? We've > been only polling since 2015 anyways. Well only a biased one, obviously: polling causes large amounts

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-24 Thread Jerry Snitselaar
Jarkko Sakkinen @ 2020-11-23 20:26 MST: > On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote: >> >> Matthew Garrett @ 2020-10-15 15:39 MST: >> >> > On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar >> > wrote: >> >> >> >> There is a misconfiguration in the bios of the gpio pin u

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-23 Thread Jarkko Sakkinen
On Tue, Nov 24, 2020 at 05:27:30AM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 19, 2020 at 03:42:35PM +0100, Hans de Goede wrote: > > Hi, > > > > On 11/19/20 7:36 AM, Jerry Snitselaar wrote: > > > > > > Matthew Garrett @ 2020-10-15 15:39 MST: > > > > > >> On Thu, Oct 15, 2020 at 2:44 PM Jerry Sn

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-23 Thread Jarkko Sakkinen
On Thu, Nov 19, 2020 at 03:42:35PM +0100, Hans de Goede wrote: > Hi, > > On 11/19/20 7:36 AM, Jerry Snitselaar wrote: > > > > Matthew Garrett @ 2020-10-15 15:39 MST: > > > >> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar > >> wrote: > >>> > >>> There is a misconfiguration in the bios of the

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-23 Thread Jarkko Sakkinen
On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote: > > Matthew Garrett @ 2020-10-15 15:39 MST: > > > On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar > > wrote: > >> > >> There is a misconfiguration in the bios of the gpio pin used for the > >> interrupt in the T490s. When interr

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-23 Thread Hans de Goede
Hi, On 11/19/20 6:05 PM, Jerry Snitselaar wrote: > > Hans de Goede @ 2020-11-19 07:42 MST: > >> Hi, >> >> On 11/19/20 7:36 AM, Jerry Snitselaar wrote: >>> >>> Matthew Garrett @ 2020-10-15 15:39 MST: >>> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote: > > There is a mi

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-19 Thread Jerry Snitselaar
Hans de Goede @ 2020-11-19 07:42 MST: > Hi, > > On 11/19/20 7:36 AM, Jerry Snitselaar wrote: >> >> Matthew Garrett @ 2020-10-15 15:39 MST: >> >>> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar >>> wrote: There is a misconfiguration in the bios of the gpio pin used for the in

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-19 Thread Hans de Goede
Hi, On 11/19/20 7:36 AM, Jerry Snitselaar wrote: > > Matthew Garrett @ 2020-10-15 15:39 MST: > >> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote: >>> >>> There is a misconfiguration in the bios of the gpio pin used for the >>> interrupt in the T490s. When interrupts are enabled in the t

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-11-18 Thread Jerry Snitselaar
Matthew Garrett @ 2020-10-15 15:39 MST: > On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote: >> >> There is a misconfiguration in the bios of the gpio pin used for the >> interrupt in the T490s. When interrupts are enabled in the tpm_tis >> driver code this results in an interrupt storm. T

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-18 Thread Jarkko Sakkinen
On Mon, Oct 19, 2020 at 12:11:44AM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 15, 2020 at 02:44:30PM -0700, Jerry Snitselaar wrote: > > There is a misconfiguration in the bios of the gpio pin used for the > > interrupt in the T490s. When interrupts are enabled in the tpm_tis > > driver code this r

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-18 Thread Jarkko Sakkinen
On Thu, Oct 15, 2020 at 02:44:30PM -0700, Jerry Snitselaar wrote: > There is a misconfiguration in the bios of the gpio pin used for the > interrupt in the T490s. When interrupts are enabled in the tpm_tis > driver code this results in an interrupt storm. This was initially > reported when we attem

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-15 Thread Hans de Goede
Hi, On 10/16/20 12:39 AM, Matthew Garrett wrote: On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote: There is a misconfiguration in the bios of the gpio pin used for the interrupt in the T490s. When interrupts are enabled in the tpm_tis driver code this results in an interrupt storm. This

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-15 Thread Hans de Goede
Hi, On 10/15/20 11:44 PM, Jerry Snitselaar wrote: There is a misconfiguration in the bios of the gpio pin used for the interrupt in the T490s. When interrupts are enabled in the tpm_tis driver code this results in an interrupt storm. This was initially reported when we attempted to enable the in

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-15 Thread Matthew Garrett
On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote: > > There is a misconfiguration in the bios of the gpio pin used for the > interrupt in the T490s. When interrupts are enabled in the tpm_tis > driver code this results in an interrupt storm. This was initially > reported when we attempted to

Re: [PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-15 Thread Jerry Snitselaar
James should this get tacked on the end of your patchset? Regards, Jerry

[PATCH] tpm_tis: Disable interrupts on ThinkPad T490s

2020-10-15 Thread Jerry Snitselaar
There is a misconfiguration in the bios of the gpio pin used for the interrupt in the T490s. When interrupts are enabled in the tpm_tis driver code this results in an interrupt storm. This was initially reported when we attempted to enable the interrupt code in the tpm_tis driver, which previously