Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Sat, Jan 30, 2021 at 04:41:13PM -0800, James Bottomley wrote: > On Sat, 2021-01-30 at 15:49 -0800, Guenter Roeck wrote: > > On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: > > > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > > > > Hi Jarkko, Guenter > > > > > > > > Yes, here are t

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Sat, Jan 30, 2021 at 03:49:09PM -0800, Guenter Roeck wrote: > On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: > > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > >> Hi Jarkko, Guenter > >> > >> Yes, here are the logs when failure occurs - > >> https://gist.github.com/semihalf-majcza

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Sat, 2021-01-30 at 19:36 -0800, Guenter Roeck wrote: > On 1/30/21 4:41 PM, James Bottomley wrote: > > On Sat, 2021-01-30 at 15:49 -0800, Guenter Roeck wrote: > > > On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: > > > > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > > > > > Hi Jark

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On 1/30/21 4:41 PM, James Bottomley wrote: > On Sat, 2021-01-30 at 15:49 -0800, Guenter Roeck wrote: >> On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: >>> On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: Hi Jarkko, Guenter Yes, here are the logs when failure occurs -

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Sat, 2021-01-30 at 15:49 -0800, Guenter Roeck wrote: > On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: > > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > > > Hi Jarkko, Guenter > > > > > > Yes, here are the logs when failure occurs - > > > https://gist.github.com/semihalf-majczak-

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: >> Hi Jarkko, Guenter >> >> Yes, here are the logs when failure occurs - >> https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 >> Look for a phrase "TPM returne

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On 1/29/21 2:49 PM, Jarkko Sakkinen wrote: > On Mon, Jan 25, 2021 at 09:18:46AM -0800, Guenter Roeck wrote: >> Hi Lukasz, >> >> On Sat, Jan 23, 2021 at 02:42:47AM +0100, Lukasz Majczak wrote: >>> There is a missing call to start_tpm_chip before the call to >>> the tpm_get_timeouts() and tpm_tis_pro

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > Hi Jarkko, Guenter > > Yes, here are the logs when failure occurs - > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > Look for a phrase "TPM returned invalid status" > > Guenter - good suggestion

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Sat, Jan 30, 2021 at 12:59:09AM +0200, Jarkko Sakkinen wrote: > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > > Hi Jarkko, Guenter > > > > Yes, here are the logs when failure occurs - > > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > > Lo

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Mon, Jan 25, 2021 at 09:18:46AM -0800, Guenter Roeck wrote: > Hi Lukasz, > > On Sat, Jan 23, 2021 at 02:42:47AM +0100, Lukasz Majczak wrote: > > There is a missing call to start_tpm_chip before the call to > > the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current > > approach ma

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Tue, Jan 26, 2021 at 08:46:48AM -0800, James Bottomley wrote: > On Tue, 2021-01-26 at 16:46 +0100, Łukasz Majczak wrote: > > Hi Jarkko, Guenter > > > > Yes, here are the logs when failure occurs - > > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > > Look for

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On 26/01/2021 16:46, James Bottomley wrote: > On Tue, 2021-01-26 at 16:46 +0100, Łukasz Majczak wrote: >> Hi Jarkko, Guenter >> >> Yes, here are the logs when failure occurs - >> https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 >> Look for a phrase "TPM returned inva

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Tue, 2021-01-26 at 16:46 +0100, Łukasz Majczak wrote: > Hi Jarkko, Guenter > > Yes, here are the logs when failure occurs - > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > Look for a phrase "TPM returned invalid status" We've had other reports of this: htt

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

Hi Jarkko, Guenter Yes, here are the logs when failure occurs - https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 Look for a phrase "TPM returned invalid status" Guenter - good suggestion - I will try to keep it as tight as possible. Best regards, Lukasz pon., 25

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

On Sat, Jan 23, 2021 at 02:42:47AM +0100, Lukasz Majczak wrote: > There is a missing call to start_tpm_chip before the call to > the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current > approach maight work for tpm2, it fails for tpm1.x - in that case > call to tpm_get_timeouts() or

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

Hi Lukasz, On Sat, Jan 23, 2021 at 02:42:47AM +0100, Lukasz Majczak wrote: > There is a missing call to start_tpm_chip before the call to > the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current > approach maight work for tpm2, it fails for tpm1.x - in that case > call to tpm_get_ti

[PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

There is a missing call to start_tpm_chip before the call to the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current approach maight work for tpm2, it fails for tpm1.x - in that case call to tpm_get_timeouts() or tpm_tis_probe_irq_single() tries to transmit TPM commands on a disabled