Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static

2017-02-20 Thread Jarkko Sakkinen
On Tue, Feb 21, 2017 at 11:20:58AM +0530, Nayna wrote: > > > On 02/17/2017 03:54 PM, Jarkko Sakkinen wrote: > > On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: > > > There's no need to export tpm2_get_pcr_alloation() because it is only > > > a helper function for tpm2_auto_startu

Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static

2017-02-20 Thread Nayna
On 02/17/2017 03:54 PM, Jarkko Sakkinen wrote: On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: There's no need to export tpm2_get_pcr_alloation() because it is only a helper function for tpm2_auto_startup(). For the same reason it does not make much sense to maintain documenta

Re: [tpmdd-devel] [PATCH] tpm: declare tpm2_get_pcr_allocation() as static

2017-02-20 Thread Jarkko Sakkinen
On Fri, Feb 17, 2017 at 12:24:27PM +0200, Jarkko Sakkinen wrote: > On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: > > There's no need to export tpm2_get_pcr_alloation() because it is only > > a helper function for tpm2_auto_startup(). For the same reason it does > > not make much

Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static

2017-02-17 Thread Jarkko Sakkinen
On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: > There's no need to export tpm2_get_pcr_alloation() because it is only > a helper function for tpm2_auto_startup(). For the same reason it does > not make much sense to maintain documentation for it. > > Signed-off-by: Jarkko Sakkin

Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static

2017-02-15 Thread Jarkko Sakkinen
On Wed, Feb 15, 2017 at 11:56:43AM -0700, Jason Gunthorpe wrote: > On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: > > There's no need to export tpm2_get_pcr_alloation() because it is only > > a helper function for tpm2_auto_startup(). For the same reason it does > > not make much

Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static

2017-02-15 Thread Jason Gunthorpe
On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote: > There's no need to export tpm2_get_pcr_alloation() because it is only > a helper function for tpm2_auto_startup(). For the same reason it does > not make much sense to maintain documentation for it. Please stop moving these functio

[PATCH] tpm: declare tpm2_get_pcr_allocation() as static

2017-02-15 Thread Jarkko Sakkinen
There's no need to export tpm2_get_pcr_alloation() because it is only a helper function for tpm2_auto_startup(). For the same reason it does not make much sense to maintain documentation for it. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm.h | 1 - drivers/char/tpm/tpm2-cmd.c |