Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-07-10 Thread Jarkko Sakkinen
On Thu, Jul 09, 2020 at 05:58:23PM -0500, Tyler Hicks wrote: > On 2020-07-03 02:57:18, Jarkko Sakkinen wrote: > > On Tue, Jun 30, 2020 at 01:33:21PM -0500, Tyler Hicks wrote: > > > Jarkko, is this an ack from you? > > > > > > Is there anything I can do to help along this fix? > > > > > > I've spo

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-07-09 Thread Tyler Hicks
On 2020-07-03 02:57:18, Jarkko Sakkinen wrote: > On Tue, Jun 30, 2020 at 01:33:21PM -0500, Tyler Hicks wrote: > > Jarkko, is this an ack from you? > > > > Is there anything I can do to help along this fix? > > > > I've spoke with two others that have poured through these specs to > > implement fi

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-07-02 Thread Jarkko Sakkinen
On Tue, Jun 30, 2020 at 01:33:21PM -0500, Tyler Hicks wrote: > Jarkko, is this an ack from you? > > Is there anything I can do to help along this fix? > > I've spoke with two others that have poured through these specs to > implement firmware event log parsers and they thought the change made > s

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-30 Thread Peter Jones
On Tue, Jun 30, 2020 at 02:23:22PM -0500, Tyler Hicks wrote: > > > I am all for stringent checks, but this could potentially break > > > measured boot on systems that are working fine today, right? > > > > Seems like in that case our measurement is unreliable and can't really > > be trusted. That

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-30 Thread Tyler Hicks
On 2020-06-30 14:53:28, Peter Jones wrote: > On Tue, Jun 16, 2020 at 11:08:38AM +0200, Ard Biesheuvel wrote: > > (cc Matthew and Peter) > > > > On Tue, 16 Jun 2020 at 01:28, Tyler Hicks > > wrote: > > > > > > Require that the TCG_PCR_EVENT2.digests.count value strictly matches the > > > value of

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-30 Thread Ard Biesheuvel
On Tue, 30 Jun 2020 at 20:53, Peter Jones wrote: > > On Tue, Jun 16, 2020 at 11:08:38AM +0200, Ard Biesheuvel wrote: > > (cc Matthew and Peter) > > > > On Tue, 16 Jun 2020 at 01:28, Tyler Hicks > > wrote: > > > > > > Require that the TCG_PCR_EVENT2.digests.count value strictly matches the > > >

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-30 Thread Peter Jones
On Tue, Jun 16, 2020 at 11:08:38AM +0200, Ard Biesheuvel wrote: > (cc Matthew and Peter) > > On Tue, 16 Jun 2020 at 01:28, Tyler Hicks wrote: > > > > Require that the TCG_PCR_EVENT2.digests.count value strictly matches the > > value of TCG_EfiSpecIdEvent.numberOfAlgorithms in the event field of t

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-30 Thread Tyler Hicks
On 2020-06-18 02:09:58, Jarkko Sakkinen wrote: > On Tue, Jun 16, 2020 at 11:08:38AM +0200, Ard Biesheuvel wrote: > > (cc Matthew and Peter) > > > > On Tue, 16 Jun 2020 at 01:28, Tyler Hicks > > wrote: > > > > > > Require that the TCG_PCR_EVENT2.digests.count value strictly matches the > > > valu

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-17 Thread Jarkko Sakkinen
On Tue, Jun 16, 2020 at 11:08:38AM +0200, Ard Biesheuvel wrote: > (cc Matthew and Peter) > > On Tue, 16 Jun 2020 at 01:28, Tyler Hicks wrote: > > > > Require that the TCG_PCR_EVENT2.digests.count value strictly matches the > > value of TCG_EfiSpecIdEvent.numberOfAlgorithms in the event field of t

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-16 Thread Tyler Hicks
On 2020-06-16 11:08:38, Ard Biesheuvel wrote: > (cc Matthew and Peter) Thanks! > On Tue, 16 Jun 2020 at 01:28, Tyler Hicks wrote: > > > > Require that the TCG_PCR_EVENT2.digests.count value strictly matches the > > value of TCG_EfiSpecIdEvent.numberOfAlgorithms in the event field of the > > TCG_

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-16 Thread Ard Biesheuvel
(cc Matthew and Peter) On Tue, 16 Jun 2020 at 01:28, Tyler Hicks wrote: > > Require that the TCG_PCR_EVENT2.digests.count value strictly matches the > value of TCG_EfiSpecIdEvent.numberOfAlgorithms in the event field of the > TCG_PCClientPCREvent event log header. Also require that > TCG_EfiSpecI

[PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-15 Thread Tyler Hicks
Require that the TCG_PCR_EVENT2.digests.count value strictly matches the value of TCG_EfiSpecIdEvent.numberOfAlgorithms in the event field of the TCG_PCClientPCREvent event log header. Also require that TCG_EfiSpecIdEvent.numberOfAlgorithms is non-zero. The TCG PC Client Platform Firmware Profile