Re: [PATCH] tools lib traceevent: Fix missing equality check for strcmp

2019-04-09 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 09, 2019 at 09:21:22AM -0400, Steven Rostedt escreveu: > > Hi Rikard, > > On Tue, 9 Apr 2019 11:15:29 +0200 > Rikard Falkeborn wrote: > > > There was a missing comparison with 0 when checking if type is "s64" or > > "u64". Therefore, the body of the if-statement was entered if "typ

Re: [PATCH] tools lib traceevent: Fix missing equality check for strcmp

2019-04-09 Thread Steven Rostedt
Hi Rikard, On Tue, 9 Apr 2019 11:15:29 +0200 Rikard Falkeborn wrote: > There was a missing comparison with 0 when checking if type is "s64" or > "u64". Therefore, the body of the if-statement was entered if "type" was > "u64" or not "s64", which made the first strcmp() redundant since if > ty

[PATCH] tools lib traceevent: Fix missing equality check for strcmp

2019-04-09 Thread Rikard Falkeborn
There was a missing comparison with 0 when checking if type is "s64" or "u64". Therefore, the body of the if-statement was entered if "type" was "u64" or not "s64", which made the first strcmp() redundant since if type is "u64", it's not "s64". If type is "s64", the body of the if-statement is not