Re: [PATCH] tools: libsubcmd: Drop the less hack that was inherited from Git.

2018-02-08 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 08, 2018 at 07:00:10PM -0500, Arvind Sankar escreveu: > We inherited this hack with the original code from the Git project. The > select call is invalid as the two fd_set pointers should not be aliased. > > We could fix it, but the Git project removed this hack in 2012 in commit > e832

Re: [PATCH] tools: libsubcmd: Drop the less hack that was inherited from Git.

2018-02-08 Thread Arvind Sankar
We inherited this hack with the original code from the Git project. The select call is invalid as the two fd_set pointers should not be aliased. We could fix it, but the Git project removed this hack in 2012 in commit e8320f3 (pager: drop "wait for output to run less" hack). The bug it worked arou

Re: [PATCH] tools: libsubcmd: Drop the less hack that was inherited from Git.

2018-02-02 Thread Arvind Sankar
Hi, it looks like Sergey has put in a patch to fix the aliasing, looking at the linux-next tree. Are we still looking to remove this hack altogether? Thanks On Thu, Jan 25, 2018 at 08:24:26AM -0500, Arvind Sankar wrote: > Thanks. > > This was found because gcc 8 appears to be enabling -Wrestric

Re: [PATCH] tools: libsubcmd: Drop the less hack that was inherited from Git.

2018-01-25 Thread Arvind Sankar
Thanks. This was found because gcc 8 appears to be enabling -Wrestrict in -Wall, so there is a build failure with mainline gcc. On Thu, Jan 25, 2018 at 05:16:52AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jan 24, 2018 at 02:54:11PM -0600, Josh Poimboeuf escreveu: > > On Tue, Jan 23, 2018 a

Re: [PATCH] tools: libsubcmd: Drop the less hack that was inherited from Git.

2018-01-25 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 24, 2018 at 02:54:11PM -0600, Josh Poimboeuf escreveu: > On Tue, Jan 23, 2018 at 07:38:37PM -0500, Arvind Sankar wrote: > > We inherited this hack with the original code from the Git project. The > > select call is invalid as the two fd_set pointers should not be aliased. > > > > We co

Re: [PATCH] tools: libsubcmd: Drop the less hack that was inherited from Git.

2018-01-24 Thread Josh Poimboeuf
On Tue, Jan 23, 2018 at 07:38:37PM -0500, Arvind Sankar wrote: > We inherited this hack with the original code from the Git project. The > select call is invalid as the two fd_set pointers should not be aliased. > > We could fix it, but the Git project removed this hack in 2012 in commit > e8320f3

[PATCH] tools: libsubcmd: Drop the less hack that was inherited from Git.

2018-01-23 Thread Arvind Sankar
We inherited this hack with the original code from the Git project. The select call is invalid as the two fd_set pointers should not be aliased. We could fix it, but the Git project removed this hack in 2012 in commit e8320f3 (pager: drop "wait for output to run less" hack). The bug it worked arou