Re: [PATCH] timers: Clear must_forward_clk inside base lock

2018-07-31 Thread Thomas Gleixner
Gaurav, On Thu, 26 Jul 2018, Gaurav Kohli wrote: > While migrating timer to new base, there is a need > to update base clk by calling forward_timer_base to > avoid stale clock , but at the same time if run_timer > is exectuing in new core it may set must_forward_clk > to false and due to this for

Re: [PATCH] timers: Clear must_forward_clk inside base lock

2018-07-31 Thread Thomas Gleixner
Gaurav, On Tue, 31 Jul 2018, Kohli, Gaurav wrote: > Can you please review below patch and update your comments: It's on the todo list already. We're not machines and a week time before sending a reminder is really appropriate. Thanks, tglx

Re: [PATCH] timers: Clear must_forward_clk inside base lock

2018-07-30 Thread Kohli, Gaurav
Hi John, Thomas, Can you please review below patch and update your comments: Regards Gaurav On 7/26/2018 2:12 PM, Gaurav Kohli wrote: While migrating timer to new base, there is a need to update base clk by calling forward_timer_base to avoid stale clock , but at the same time if run_timer is

[PATCH] timers: Clear must_forward_clk inside base lock

2018-07-26 Thread Gaurav Kohli
While migrating timer to new base, there is a need to update base clk by calling forward_timer_base to avoid stale clock , but at the same time if run_timer is exectuing in new core it may set must_forward_clk to false and due to this forward base logic may fail as per below check: if (likely(!bas