Re: [PATCH] ti-msgmgr: fix of_irq_get_byname() error check

On 07/30/2017 12:04 AM, Sergei Shtylyov wrote: of_irq_get_byname() may return 0 as well as negative error number on failure, while the driver only checks for the negative values. The driver would then call request_irq(0, ...) in ti_msgmgr_queue_startup() and never get a valid channel interrupt

Re: [PATCH] ti-msgmgr: fix of_irq_get_byname() error check

Forgot to mention that the patch is against the Linus' repo.

[PATCH] ti-msgmgr: fix of_irq_get_byname() error check

of_irq_get_byname() may return 0 as well as negative error number on failure, while the driver only checks for the negative values. The driver would then call request_irq(0, ...) in ti_msgmgr_queue_startup() and never get a valid channel interrupt. Check for 'qinst->irq <= 0' instead and return