Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Daniel Lezcano
On 20/04/2021 17:24, Frank Wunderlich wrote: > Am 20. April 2021 17:18:32 MESZ schrieb Daniel Lezcano > : >> >> Hi Frank, > >> The no_hwmon usage is a bit fuzzy in the thermal core code. > > Maybe add depency in Kconfig? Else we can get undefined symbols on linking > > regards Frank Nope, ther

Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Frank Wunderlich
Am 20. April 2021 17:18:32 MESZ schrieb Daniel Lezcano : > >Hi Frank, >The no_hwmon usage is a bit fuzzy in the thermal core code. Maybe add depency in Kconfig? Else we can get undefined symbols on linking regards Frank

Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Daniel Lezcano
Hi Frank, On 20/04/2021 16:59, Frank Wunderlich wrote: > Hi, > >> Gesendet: Dienstag, 20. April 2021 um 14:07 Uhr >> Von: "Daniel Lezcano" > >> No #ifdef in C file. > ... > >> devm_thermal_add_hwmon_sysfs() ? > > based on your comments this should be enough/right? > > #if IS_ENABLED(CONFIG

Aw: Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Frank Wunderlich
Hi, > Gesendet: Dienstag, 20. April 2021 um 14:07 Uhr > Von: "Daniel Lezcano" > No #ifdef in C file. ... > devm_thermal_add_hwmon_sysfs() ? based on your comments this should be enough/right? #if IS_ENABLED(CONFIG_THERMAL_HWMON) tzdev->tzp->no_hwmon = false; ret = devm_thermal_add_hwm

Re: [PATCH] thermal: mediatek: add sensors-support

2021-04-20 Thread Daniel Lezcano
On 20/03/2021 09:06, Frank Wunderlich wrote: > From: Frank Wunderlich > > add HWMON-support to mediateks thermanl driver to allow lm-sensors > userspace tools read soc temperature > > Signed-off-by: Frank Wunderlich > --- > drivers/thermal/mtk_thermal.c | 22 ++ > 1 file ch

Aw: [PATCH] thermal: mediatek: add sensors-support

2021-04-18 Thread Frank Wunderlich
Hi, any opinion (except typo)? thermanl => thermal regards Frank > Gesendet: Samstag, 20. März 2021 um 10:06 Uhr > Von: "Frank Wunderlich" > add HWMON-support to mediateks thermanl driver to allow lm-sensors > userspace tools read soc temperature

[PATCH] thermal: mediatek: add sensors-support

2021-03-20 Thread Frank Wunderlich
From: Frank Wunderlich add HWMON-support to mediateks thermanl driver to allow lm-sensors userspace tools read soc temperature Signed-off-by: Frank Wunderlich --- drivers/thermal/mtk_thermal.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/thermal/mtk_therm