Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-08-03 Thread Radivoje Jovanovic
On Mon, 3 Aug 2015 08:43:25 +0530 Viresh Kumar wrote: > On 01-08-15, 17:04, Viresh Kumar wrote: > > On 31-07-15, 08:30, Radivoje Jovanovic wrote: > > > > I agree with you that this patch is trivial for the current > > > implementation since the notifier, as it is currently, will > > > enforce cp

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-08-02 Thread Viresh Kumar
On 01-08-15, 17:04, Viresh Kumar wrote: > On 31-07-15, 08:30, Radivoje Jovanovic wrote: > > I agree with you that this patch is trivial for the current > > implementation since the notifier, as it is currently, will enforce > > cpu_cooling policy change at every CPUFREQ_ADJUST which would cause >

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-08-01 Thread Viresh Kumar
On 31-07-15, 08:30, Radivoje Jovanovic wrote: > I just looked over the notifier in the current upstream (my patch was > made on our production kernel which is 3.14 and has old notifier > implementation with notifier_device in place) and I see your point. That's disappointing. You were expected to

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-31 Thread Radivoje Jovanovic
On Fri, 31 Jul 2015 08:48:41 +0530 Viresh Kumar wrote: > Thanks. > > I will try to add more layman terms here to map cooling state with > frequencies. So, the cooling state 0 maps to the highest frequency the > cpufreq table supports, and the highest cooling state n maps to the > lowest frequenc

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-30 Thread Viresh Kumar
Thanks. I will try to add more layman terms here to map cooling state with frequencies. So, the cooling state 0 maps to the highest frequency the cpufreq table supports, and the highest cooling state n maps to the lowest frequency. Right ? On 30-07-15, 13:21, Radivoje Jovanovic wrote: > In this c

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-30 Thread Radivoje Jovanovic
On Thu, 30 Jul 2015 13:35:41 +0530 Viresh Kumar wrote: Hi Viresh, > Cc'ing Rafael as well.. > > On 29-07-15, 17:46, Punit Agrawal wrote: > > [ adding Viresh ] > > Thanks. That earned me few more patches ;) > > > Radivoje Jovanovic writes: > > > > > Hi Agarwal, > > > > > > On Fri, 24 Jul 201

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-30 Thread Viresh Kumar
Cc'ing Rafael as well.. On 29-07-15, 17:46, Punit Agrawal wrote: > [ adding Viresh ] Thanks. That earned me few more patches ;) > Radivoje Jovanovic writes: > > > Hi Agarwal, > > > > On Fri, 24 Jul 2015 16:26:12 +0100 > > Punit Agrawal wrote: > > > >> Radivoje Jovanovic writes: > >> > >> >

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-29 Thread Radivoje Jovanovic
On Wed, 29 Jul 2015 17:46:37 +0100 Punit Agrawal wrote: Hi Agarwal, > [ adding Viresh ] > > Radivoje Jovanovic writes: > > > Hi Agarwal, > > > > On Fri, 24 Jul 2015 16:26:12 +0100 > > Punit Agrawal wrote: > > > >> Radivoje Jovanovic writes: > >> > >> > From: Radivoje Jovanovic > >> > > >>

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-29 Thread Punit Agrawal
[ adding Viresh ] Radivoje Jovanovic writes: > Hi Agarwal, > > On Fri, 24 Jul 2015 16:26:12 +0100 > Punit Agrawal wrote: > >> Radivoje Jovanovic writes: >> >> > From: Radivoje Jovanovic >> > >> > there is no need to keep local state variable. if another driver >> > changes the policy under o

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-24 Thread Radivoje Jovanovic
Hi Agarwal, On Fri, 24 Jul 2015 16:26:12 +0100 Punit Agrawal wrote: > Radivoje Jovanovic writes: > > > From: Radivoje Jovanovic > > > > there is no need to keep local state variable. if another driver > > changes the policy under our feet the cpu_cooling driver will > > have the wrong state.

Re: [PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-24 Thread Punit Agrawal
Radivoje Jovanovic writes: > From: Radivoje Jovanovic > > there is no need to keep local state variable. if another driver > changes the policy under our feet the cpu_cooling driver will > have the wrong state. Get current state from the policy directly instead > Although the patch below looks

[PATCH] thermal/cpu_cooling: remove local cooling state variable

2015-07-21 Thread Radivoje Jovanovic
From: Radivoje Jovanovic there is no need to keep local state variable. if another driver changes the policy under our feet the cpu_cooling driver will have the wrong state. Get current state from the policy directly instead Signed-off-by: Radivoje Jovanovic --- drivers/thermal/cpu_cooling.c |