Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-08 Thread Sebastian Reichel
Hi, On Mon, Oct 05, 2020 at 04:44:17AM +, Harley A.W. Lorenzo wrote: > On Monday, October 5, 2020 12:19 AM, Joe Perches wrote: > > I did not suggest this. > > My apologies. Revised patch (still diffing from Xiongfeng Wang) here. > > [PATCH v2] test_power: revise parameter printing to use sp

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-04 Thread Harley A.W. Lorenzo
On Monday, October 5, 2020 12:19 AM, Joe Perches wrote: > I did not suggest this. My apologies. Revised patch (still diffing from Xiongfeng Wang) here. [PATCH v2] test_power: revise parameter printing to use sprintf Signed-off-by: Harley A.W. Lorenzo Suggested-by: Joe Perches --- drivers/pow

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-04 Thread Joe Perches
On Mon, 2020-10-05 at 01:30 +, Harley A.W. Lorenzo wrote: > Here is the updated patch using sprintf, diffing from the original patch by > Xiongfeng Wang. > > [PATCH] test_power: revise parameter printing to use sprintf > > Signed-off-by: Harley A.W. Lorenzo > Suggested-by: Joe Perches I d

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-04 Thread Harley A.W. Lorenzo
Here is the updated patch using sprintf, diffing from the original patch by Xiongfeng Wang. [PATCH] test_power: revise parameter printing to use sprintf Signed-off-by: Harley A.W. Lorenzo Suggested-by: Joe Perches --- drivers/power/supply/test_power.c | 27 ++- 1 file

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-04 Thread Sebastian Reichel
Hi, On Sat, Oct 03, 2020 at 02:55:41PM -0700, Joe Perches wrote: > On Sat, 2020-10-03 at 23:50 +0200, Sebastian Reichel wrote: > > Hi, > > > > On Sat, Oct 03, 2020 at 02:43:09PM -0700, Joe Perches wrote: > > > On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel wrote: > > > > On Fri, Sep 04, 202

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-03 Thread Joe Perches
On Sat, 2020-10-03 at 23:50 +0200, Sebastian Reichel wrote: > Hi, > > On Sat, Oct 03, 2020 at 02:43:09PM -0700, Joe Perches wrote: > > On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel wrote: > > > On Fri, Sep 04, 2020 at 02:09:58PM +0800, Xiongfeng Wang wrote: > > > > When I cat some module pa

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-03 Thread Sebastian Reichel
Hi, On Sat, Oct 03, 2020 at 02:43:09PM -0700, Joe Perches wrote: > On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel wrote: > > On Fri, Sep 04, 2020 at 02:09:58PM +0800, Xiongfeng Wang wrote: > > > When I cat some module parameters by sysfs, it displays as follows. > > > It's better to add a ne

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-03 Thread Joe Perches
On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel wrote: > Hi, > > On Fri, Sep 04, 2020 at 02:09:58PM +0800, Xiongfeng Wang wrote: > > When I cat some module parameters by sysfs, it displays as follows. > > It's better to add a newline for easy reading. [] > > root@syzkaller:~# cd /sys/module/t

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-03 Thread Sebastian Reichel
Hi, On Fri, Sep 04, 2020 at 02:09:58PM +0800, Xiongfeng Wang wrote: > When I cat some module parameters by sysfs, it displays as follows. > It's better to add a newline for easy reading. > > root@syzkaller:~# cd /sys/module/test_power/parameters/ > root@syzkaller:/sys/module/test_power/parameters

[PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-09-03 Thread Xiongfeng Wang
When I cat some module parameters by sysfs, it displays as follows. It's better to add a newline for easy reading. root@syzkaller:~# cd /sys/module/test_power/parameters/ root@syzkaller:/sys/module/test_power/parameters# cat ac_online onroot@syzkaller:/sys/module/test_power/parameters# cat battery