Re: [PATCH] tcp: Modify the condition for the first skb to collapse

2013-06-17 Thread Eric Dumazet
On Tue, 2013-06-18 at 05:52 -0400, Jun Chen wrote: > > > There are many warning for tcp_recvmsg before this crash. I can't find > other memory warning in the logs, but I'm not sure whether there are > memory issues because of the length limitation of saved logs. I think > this logs will give you m

Re: [PATCH] tcp: Modify the condition for the first skb to collapse

2013-06-17 Thread Jun Chen
On Mon, 2013-06-17 at 06:21 -0700, Eric Dumazet wrote: > On Mon, 2013-06-17 at 14:52 -0400, Jun Chen wrote: > > On Mon, 2013-06-17 at 03:29 -0700, Eric Dumazet wrote: > > > On Mon, 2013-06-17 at 13:29 -0400, Jun Chen wrote: > > > > > > > > > hi, > > > > When the condition of tcp_win_from_space(skb

Re: [PATCH] tcp: Modify the condition for the first skb to collapse

2013-06-17 Thread Eric Dumazet
On Mon, 2013-06-17 at 14:52 -0400, Jun Chen wrote: > On Mon, 2013-06-17 at 03:29 -0700, Eric Dumazet wrote: > > On Mon, 2013-06-17 at 13:29 -0400, Jun Chen wrote: > > > > > > > hi, > > > When the condition of tcp_win_from_space(skb->truesize) > skb->len is > > > true but the before(start, TCP_SKB_

Re: [PATCH] tcp: Modify the condition for the first skb to collapse

2013-06-17 Thread Jun Chen
On Mon, 2013-06-17 at 03:29 -0700, Eric Dumazet wrote: > On Mon, 2013-06-17 at 13:29 -0400, Jun Chen wrote: > > > > > hi, > > When the condition of tcp_win_from_space(skb->truesize) > skb->len is > > true but the before(start, TCP_SKB_CB(skb)->seq) is also true, the final > > condition will be tru

Re: [PATCH] tcp: Modify the condition for the first skb to collapse

2013-06-17 Thread Eric Dumazet
On Mon, 2013-06-17 at 13:29 -0400, Jun Chen wrote: > > > hi, > When the condition of tcp_win_from_space(skb->truesize) > skb->len is > true but the before(start, TCP_SKB_CB(skb)->seq) is also true, the final > condition will be true. The follow line: > int offset = start - TCP_SKB_CB(skb)->seq; >

Re: [PATCH] tcp: Modify the condition for the first skb to collapse

2013-06-17 Thread Jun Chen
On Mon, 2013-06-17 at 01:15 -0700, Eric Dumazet wrote: > On Mon, 2013-06-17 at 10:18 -0400, Jun Chen wrote: > > When search the first skb to collapse,the condition of overlap to the next > > one have been > > reached,but the start is less than TCP_SKB_CB(skb)->seq at this time, then > > followed

Re: [PATCH] tcp: Modify the condition for the first skb to collapse

2013-06-17 Thread Eric Dumazet
On Mon, 2013-06-17 at 10:18 -0400, Jun Chen wrote: > When search the first skb to collapse,the condition of overlap to the next > one have been > reached,but the start is less than TCP_SKB_CB(skb)->seq at this time, then > followed process > will trigger the BUG_ON of the offset(start - TCP_SKB_C

[PATCH] tcp: Modify the condition for the first skb to collapse

2013-06-16 Thread Jun Chen
When search the first skb to collapse,the condition of overlap to the next one have been reached,but the start is less than TCP_SKB_CB(skb)->seq at this time, then followed process will trigger the BUG_ON of the offset(start - TCP_SKB_CB(skb)->seq). So this patch add one check (! before(start,TC