Re: [PATCH] sysfs: use a separate locking class for open files depending on mmap

2013-11-19 Thread Tejun Heo
On Sun, Nov 17, 2013 at 08:45:23PM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 17, 2013 at 12:29:37PM +0900, Tejun Heo wrote: > > On Sat, Nov 16, 2013 at 10:21:19PM -0500, Dave Jones wrote: > > > On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote: > > > > > > > > > > + if (has_mm

Re: [PATCH] sysfs: use a separate locking class for open files depending on mmap

2013-11-17 Thread Greg Kroah-Hartman
On Sun, Nov 17, 2013 at 12:29:37PM +0900, Tejun Heo wrote: > On Sat, Nov 16, 2013 at 10:21:19PM -0500, Dave Jones wrote: > > On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote: > > > > > > > +if (has_mmap) > > > +mutex_init(&of->mutex); > > > +else > >

Re: [PATCH] sysfs: use a separate locking class for open files depending on mmap

2013-11-16 Thread Tejun Heo
On Sat, Nov 16, 2013 at 10:21:19PM -0500, Dave Jones wrote: > On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote: > > > > + if (has_mmap) > > + mutex_init(&of->mutex); > > + else > > + mutex_init(&of->mutex); > > ummm... Supposed to look that way. It'll give two

Re: [PATCH] sysfs: use a separate locking class for open files depending on mmap

2013-11-16 Thread Dave Jones
On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote: > +if (has_mmap) > +mutex_init(&of->mutex); > +else > +mutex_init(&of->mutex); ummm... Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH] sysfs: use a separate locking class for open files depending on mmap

2013-11-16 Thread Tejun Heo
The following two commits implemented mmap support in the regular file path and merged bin file support into the regular path. 73d9714627ad ("sysfs: copy bin mmap support from fs/sysfs/bin.c to fs/sysfs/file.c") 3124eb1679b2 ("sysfs: merge regular and bin file handling") After the merge, the f