Re: [PATCH] sysctl: const-ify ngroups_max

2020-05-18 Thread Kees Cook
On Mon, May 18, 2020 at 06:30:55PM +, Luis Chamberlain wrote: > On Mon, May 18, 2020 at 11:17:47AM -0700, Kees Cook wrote: > > On Mon, May 18, 2020 at 05:25:09PM +, Luis Chamberlain wrote: > > > On Mon, May 18, 2020 at 09:08:22AM -0700, Kees Cook wrote: > > > > On Mon, May 18, 2020 at 05:57

Re: [PATCH] sysctl: const-ify ngroups_max

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 11:17:47AM -0700, Kees Cook wrote: > On Mon, May 18, 2020 at 05:25:09PM +, Luis Chamberlain wrote: > > On Mon, May 18, 2020 at 09:08:22AM -0700, Kees Cook wrote: > > > On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote: > > > > ngroups_max is a read-only sysctl

Re: [PATCH] sysctl: const-ify ngroups_max

2020-05-18 Thread Kees Cook
On Mon, May 18, 2020 at 05:25:09PM +, Luis Chamberlain wrote: > On Mon, May 18, 2020 at 09:08:22AM -0700, Kees Cook wrote: > > On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote: > > > ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make > > > it const, in the same wa

Re: [PATCH] sysctl: const-ify ngroups_max

2020-05-18 Thread Luis Chamberlain
On Mon, May 18, 2020 at 09:08:22AM -0700, Kees Cook wrote: > On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote: > > ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make > > it const, in the same way as cap_last_cap. > > > > Signed-off-by: Stephen Kitt > > Reviewed-by:

Re: [PATCH] sysctl: const-ify ngroups_max

2020-05-18 Thread Kees Cook
On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote: > ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make > it const, in the same way as cap_last_cap. > > Signed-off-by: Stephen Kitt Reviewed-by: Kees Cook -- Kees Cook

[PATCH] sysctl: const-ify ngroups_max

2020-05-18 Thread Stephen Kitt
ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make it const, in the same way as cap_last_cap. Signed-off-by: Stephen Kitt --- This is split out from 2f4c33063ad7 ("docs: sysctl/kernel: document ngroups_max") which conflicted with f461d2dcd511 ("sysctl: avoid forward declaration