Re: [PATCH] svm: Fix improper check when deactivate AVIC

2019-02-04 Thread Suthikulpanit, Suravee
Paolo, On 2/1/19 6:01 PM, Suravee Suthikulpanit wrote: > Paolo, > > On 1/30/19 11:22 PM, Paolo Bonzini wrote: >> On 29/01/19 09:09, Suthikulpanit, Suravee wrote: >>> The function svm_refresh_apicv_exec_ctrl() always returning prematurely >>> as kvm_vcpu_apicv_active() always return false when cal

Re: [PATCH] svm: Fix improper check when deactivate AVIC

2019-02-01 Thread Suthikulpanit, Suravee
Paolo, On 1/30/19 11:22 PM, Paolo Bonzini wrote: > On 29/01/19 09:09, Suthikulpanit, Suravee wrote: >> The function svm_refresh_apicv_exec_ctrl() always returning prematurely >> as kvm_vcpu_apicv_active() always return false when calling from >> the function arch/x86/kvm/x86.c:kvm_vcpu_deactivate_

Re: [PATCH] svm: Fix improper check when deactivate AVIC

2019-01-30 Thread Paolo Bonzini
On 29/01/19 09:09, Suthikulpanit, Suravee wrote: > The function svm_refresh_apicv_exec_ctrl() always returning prematurely > as kvm_vcpu_apicv_active() always return false when calling from > the function arch/x86/kvm/x86.c:kvm_vcpu_deactivate_apicv(). > This is because the apicv_active is set to f

[PATCH] svm: Fix improper check when deactivate AVIC

2019-01-29 Thread Suthikulpanit, Suravee
The function svm_refresh_apicv_exec_ctrl() always returning prematurely as kvm_vcpu_apicv_active() always return false when calling from the function arch/x86/kvm/x86.c:kvm_vcpu_deactivate_apicv(). This is because the apicv_active is set to false just before calling refresh_apicv_exec_ctrl(). Also