Re: [PATCH] svcrdma: delete double assignment

2014-07-30 Thread Steve Wise
On 7/29/2014 5:50 PM, David Miller wrote: From: Himangi Saraogi Date: Mon, 28 Jul 2014 20:59:38 +0530 Delete successive assignments to the same location. A simplified version of Coccinelle semantic match that finds this problem is as follows: // @@ expression i; @@ *i = ...; i = ...; //

Re: [PATCH] svcrdma: delete double assignment

2014-07-29 Thread David Miller
From: Himangi Saraogi Date: Mon, 28 Jul 2014 20:59:38 +0530 > Delete successive assignments to the same location. > > A simplified version of Coccinelle semantic match that finds this problem is > as > follows: > > // > @@ > expression i; > @@ > > *i = ...; > i = ...; > // > > Signed-off-

[PATCH] svcrdma: delete double assignment

2014-07-28 Thread Himangi Saraogi
Delete successive assignments to the same location. A simplified version of Coccinelle semantic match that finds this problem is as follows: // @@ expression i; @@ *i = ...; i = ...; // Signed-off-by: Himangi Saraogi --- Should the assignment be the maximum of the 2 values? net/sunrpc/xprt