Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-14 Thread Bob Liu
On 11/15/2013 12:21 AM, Seth Jennings wrote: > On Wed, Nov 13, 2013 at 08:00:34PM -0800, Hugh Dickins wrote: >> On Wed, 13 Nov 2013, Minchan Kim wrote: >> ... >>> >>> Hello Andrew, >>> >>> I'd like to listen your opinion. >>> >>> The zram promotion trial started since Aug 2012 and I already have g

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-14 Thread Minchan Kim
Hello Hugh, On Wed, Nov 13, 2013 at 08:00:34PM -0800, Hugh Dickins wrote: > On Wed, 13 Nov 2013, Minchan Kim wrote: > > On Thu, Nov 07, 2013 at 04:04:51PM +0900, Minchan Kim wrote: > > > On Wed, Nov 06, 2013 at 07:05:11PM -0800, Greg KH wrote: > > > > On Wed, Nov 06, 2013 at 03:46:19PM -0800, Niti

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-14 Thread Seth Jennings
On Wed, Nov 13, 2013 at 08:00:34PM -0800, Hugh Dickins wrote: > On Wed, 13 Nov 2013, Minchan Kim wrote: > > On Thu, Nov 07, 2013 at 04:04:51PM +0900, Minchan Kim wrote: > > > On Wed, Nov 06, 2013 at 07:05:11PM -0800, Greg KH wrote: > > > > On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-13 Thread Hugh Dickins
On Wed, 13 Nov 2013, Minchan Kim wrote: > On Thu, Nov 07, 2013 at 04:04:51PM +0900, Minchan Kim wrote: > > On Wed, Nov 06, 2013 at 07:05:11PM -0800, Greg KH wrote: > > > On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote: > > > > I'm getting really tired of them hanging around in here for

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-12 Thread Nitin Gupta
On 11/12/13, 6:42 PM, Greg KH wrote: On Wed, Nov 13, 2013 at 12:41:38AM +0900, Minchan Kim wrote: We spent much time with preventing zram enhance since it have been in staging and Greg never want to improve without promotion. It's not "improve", it's "Greg does not want you adding new features

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-12 Thread Greg KH
On Wed, Nov 13, 2013 at 12:41:38AM +0900, Minchan Kim wrote: > We spent much time with preventing zram enhance since it have been in staging > and Greg never want to improve without promotion. It's not "improve", it's "Greg does not want you adding new features and functionality while the code is

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-12 Thread Minchan Kim
On Thu, Nov 07, 2013 at 04:04:51PM +0900, Minchan Kim wrote: > On Wed, Nov 06, 2013 at 07:05:11PM -0800, Greg KH wrote: > > On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote: > > > I'm getting really tired of them hanging around in here for many years > > > > now... > > > > > > > > > >

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-08 Thread Bob Liu
On 11/07/2013 03:04 PM, Minchan Kim wrote: > On Wed, Nov 06, 2013 at 07:05:11PM -0800, Greg KH wrote: >> On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote: >> > I'm getting really tired of them hanging around in here for many years now... >>> >>> Minchan has tried many times to

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-07 Thread Greg KH
On Thu, Nov 07, 2013 at 09:06:26AM -0800, Luigi Semenzato wrote: > If I may add my usual 2c (and some news): > > zram is used by default on all Chrome OS devices. I can't say how > many devices, but it's not a small number, google it, and it's an > important market, low-end laptops for education

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-07 Thread Olav Haugan
On 11/6/2013 7:06 PM, Greg KH wrote: > On Wed, Nov 06, 2013 at 04:00:02PM -0800, Olav Haugan wrote: >> On 11/5/2013 5:56 PM, Greg KH wrote: >>> On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: zsmalloc encodes a handle using the page pfn and an object index. On some hardware p

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-07 Thread Luigi Semenzato
On Thu, Nov 7, 2013 at 9:06 AM, Luigi Semenzato wrote: -> Android 4.4 KitKat is also using zram, to better support devices with -> less than 1 MB RAM. (That's the news.) Sorry, I meant 1 GB RAM. http://dilbert.com/strips/comic/1991-09-27/ -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-07 Thread Rik van Riel
On 11/07/2013 02:04 AM, Minchan Kim wrote: I'm guilty and I have been busy by other stuff. Sorry for that. Fortunately, I discussed this issue with Hugh in this Linuxcon for a long time(Thanks Hugh!) he felt zram's block device abstraction is better design rather than frontswap backend stuff alt

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-07 Thread Luigi Semenzato
If I may add my usual 2c (and some news): zram is used by default on all Chrome OS devices. I can't say how many devices, but it's not a small number, google it, and it's an important market, low-end laptops for education and the less affluent. It has been available experimentally for well over

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Minchan Kim
On Wed, Nov 06, 2013 at 07:05:11PM -0800, Greg KH wrote: > On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote: > > I'm getting really tired of them hanging around in here for many years > > > now... > > > > > > > Minchan has tried many times to promote zram out of staging. This was > > h

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Greg KH
On Wed, Nov 06, 2013 at 04:00:02PM -0800, Olav Haugan wrote: > On 11/5/2013 5:56 PM, Greg KH wrote: > > On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: > >> zsmalloc encodes a handle using the page pfn and an object > >> index. On some hardware platforms the pfn could be 0 and this > >

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Greg KH
On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote: > I'm getting really tired of them hanging around in here for many years > > now... > > > > Minchan has tried many times to promote zram out of staging. This was > his most recent attempt: > > https://lkml.org/lkml/2013/8/21/54 > > Th

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Olav Haugan
On 11/5/2013 5:56 PM, Greg KH wrote: > On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: >> zsmalloc encodes a handle using the page pfn and an object >> index. On some hardware platforms the pfn could be 0 and this >> causes the encoded handle to be 0 which is interpreted as an >> alloc

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Olav Haugan
On 11/6/2013 12:56 PM, Nitin Gupta wrote: > On Tue, Nov 5, 2013 at 5:17 PM, David Cohen > wrote: >> Hi Olav, >> >> >> On 11/05/2013 04:54 PM, Olav Haugan wrote: >>> >>> zsmalloc encodes a handle using the page pfn and an object >>> index. On some hardware platforms the pfn could be 0 and this >>>

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Nitin Gupta
On Wed, Nov 6, 2013 at 2:10 PM, Greg KH wrote: > On Wed, Nov 06, 2013 at 01:09:59PM -0800, Nitin Gupta wrote: >> On Tue, Nov 5, 2013 at 5:56 PM, Greg KH wrote: >> > On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: >> >> zsmalloc encodes a handle using the page pfn and an object >> >>

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Greg KH
On Wed, Nov 06, 2013 at 01:09:59PM -0800, Nitin Gupta wrote: > On Tue, Nov 5, 2013 at 5:56 PM, Greg KH wrote: > > On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: > >> zsmalloc encodes a handle using the page pfn and an object > >> index. On some hardware platforms the pfn could be 0 a

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Nitin Gupta
On Tue, Nov 5, 2013 at 5:56 PM, Greg KH wrote: > On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: >> zsmalloc encodes a handle using the page pfn and an object >> index. On some hardware platforms the pfn could be 0 and this >> causes the encoded handle to be 0 which is interpreted as

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Nitin Gupta
On Tue, Nov 5, 2013 at 5:17 PM, David Cohen wrote: > Hi Olav, > > > On 11/05/2013 04:54 PM, Olav Haugan wrote: >> >> zsmalloc encodes a handle using the page pfn and an object >> index. On some hardware platforms the pfn could be 0 and this >> causes the encoded handle to be 0 which is interpreted

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-05 Thread Greg KH
On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: > zsmalloc encodes a handle using the page pfn and an object > index. On some hardware platforms the pfn could be 0 and this > causes the encoded handle to be 0 which is interpreted as an > allocation failure. What platforms specifically

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-05 Thread David Cohen
Hi Olav, On 11/05/2013 04:54 PM, Olav Haugan wrote: zsmalloc encodes a handle using the page pfn and an object index. On some hardware platforms the pfn could be 0 and this causes the encoded handle to be 0 which is interpreted as an allocation failure. To prevent this false error we ensure tha

[PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-05 Thread Olav Haugan
zsmalloc encodes a handle using the page pfn and an object index. On some hardware platforms the pfn could be 0 and this causes the encoded handle to be 0 which is interpreted as an allocation failure. To prevent this false error we ensure that the encoded handle will not be 0 when allocation succ