Re: [PATCH] staging: silicom: hide conditionally used function in condition

2014-03-26 Thread SeongJae Park
On Wed, Mar 26, 2014 at 9:27 PM, Greg KH wrote: > On Wed, Mar 26, 2014 at 02:58:50PM +0900, SeongJae Park wrote: >> bp_proc_create() be called only when BP_PROC_SUPPORT defined but its >> definition live outside of #ifdef BP_PROC_SUPPORT and cause following >> trivial build warning: >> drivers/sta

Re: [PATCH] staging: silicom: hide conditionally used function in condition

2014-03-26 Thread Greg KH
On Wed, Mar 26, 2014 at 02:58:50PM +0900, SeongJae Park wrote: > bp_proc_create() be called only when BP_PROC_SUPPORT defined but its > definition live outside of #ifdef BP_PROC_SUPPORT and cause following > trivial build warning: > drivers/staging/silicom/bpctl_mod.c:6786:12: warning: > ‘bp_proc_c

[PATCH] staging: silicom: hide conditionally used function in condition

2014-03-25 Thread SeongJae Park
bp_proc_create() be called only when BP_PROC_SUPPORT defined but its definition live outside of #ifdef BP_PROC_SUPPORT and cause following trivial build warning: drivers/staging/silicom/bpctl_mod.c:6786:12: warning: ‘bp_proc_create’ defined but not used [-Wunused-function] static int bp_proc_creat