Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-25 Thread Andy Shevchenko
On Fri, Jun 22, 2018 at 8:28 PM, Joe Perches wrote: > On Fri, 2018-06-22 at 14:48 +0200, Michael Straube wrote: >> On 06/22/18 12:57, Dan Carpenter wrote: > Output from checkpatch is not gospel and can be ignored > whenever appropriate. > > I think the below is ok: > > if ((is_broadcast_e

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-22 Thread Joe Perches
On Fri, 2018-06-22 at 21:11 +0200, Michael Straube wrote: > On 06/22/18 19:28, Joe Perches wrote: > > Although the last memcpy of a fixed mac address could > > probably use eth_random_addr to reduce the likelihood > > of mac address collision so maybe > > eth_random_addr(mac_addr); > Us

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-22 Thread Michael Straube
On 06/22/18 19:28, Joe Perches wrote: On Fri, 2018-06-22 at 14:48 +0200, Michael Straube wrote: On 06/22/18 12:57, Dan Carpenter wrote: On Fri, Jun 22, 2018 at 03:54:22AM -0700, Joe Perches wrote: On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote: On Thu, Jun 21, 2018 at 08:22:30PM +0200

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-22 Thread Joe Perches
On Fri, 2018-06-22 at 14:48 +0200, Michael Straube wrote: > On 06/22/18 12:57, Dan Carpenter wrote: > > On Fri, Jun 22, 2018 at 03:54:22AM -0700, Joe Perches wrote: > > > On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote: > > > > On Thu, Jun 21, 2018 at 08:22:30PM +0200, Michael Straube wrote:

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-22 Thread Michael Straube
On 06/22/18 12:57, Dan Carpenter wrote: On Fri, Jun 22, 2018 at 03:54:22AM -0700, Joe Perches wrote: On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote: On Thu, Jun 21, 2018 at 08:22:30PM +0200, Michael Straube wrote: Fix checkpatch error 'do not use assignment in if condition'. [] diff

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-22 Thread Joe Perches
On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote: > On Thu, Jun 21, 2018 at 08:22:30PM +0200, Michael Straube wrote: > > Fix checkpatch error 'do not use assignment in if condition'. [] > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c > > b/drivers/staging/rtl8723bs/core/rtw_i

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-22 Thread Dan Carpenter
On Fri, Jun 22, 2018 at 03:54:22AM -0700, Joe Perches wrote: > On Fri, 2018-06-22 at 13:40 +0300, Dan Carpenter wrote: > > On Thu, Jun 21, 2018 at 08:22:30PM +0200, Michael Straube wrote: > > > Fix checkpatch error 'do not use assignment in if condition'. > [] > > > diff --git a/drivers/staging/rtl

Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-22 Thread Dan Carpenter
On Thu, Jun 21, 2018 at 08:22:30PM +0200, Michael Straube wrote: > Fix checkpatch error 'do not use assignment in if condition'. > > Signed-off-by: Michael Straube > --- > drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git

[PATCH] staging: rtl8723bs: do not use assignment in if condition

2018-06-21 Thread Michael Straube
Fix checkpatch error 'do not use assignment in if condition'. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/cor