Re: [PATCH] staging: rtl8712: reduce stack usage

2016-02-19 Thread Dan Carpenter
Of course, we still reach almost the same maximum stack usage as before because we're going to put the function on stack in the end anyway. regards, dan carpenter

Re: [PATCH] staging: rtl8712: reduce stack usage

2016-02-18 Thread Arnd Bergmann
On Wednesday 17 February 2016 20:20:15 Larry Finger wrote: > > --- > > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > As there is no reason for translate_scan() to be inlined, this patch seems > reasonable The largest user of stack l

Re: [PATCH] staging: rtl8712: reduce stack usage

2016-02-17 Thread Larry Finger
On 02/17/2016 02:32 AM, Arnd Bergmann wrote: The "translate_scan" function in rtl8712 uses a lot of stack, and gets inlined into its single caller, r8711_wx_get_scan, which in some configurations now blows the 1024 byte stack warning limit: drivers/staging/rtl8712/rtl871x_ioctl_linux.c: In funct

[PATCH] staging: rtl8712: reduce stack usage

2016-02-17 Thread Arnd Bergmann
The "translate_scan" function in rtl8712 uses a lot of stack, and gets inlined into its single caller, r8711_wx_get_scan, which in some configurations now blows the 1024 byte stack warning limit: drivers/staging/rtl8712/rtl871x_ioctl_linux.c: In function 'r8711_wx_get_scan': drivers/staging/rtl871