Oh. I use a script to check these... It doesn't break anything except
for that commented out code which should be deleted anyway.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordom
On 10/15/2015 06:40 AM, Dan Carpenter wrote:
On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote:
and make sure you don't break the driver.
I'm not seeing how this patch breaks anything? What am I missing?
Did you apply it and then compile the result? If not, then how can you
asse
On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote:
> and make sure you don't break the driver.
I'm not seeing how this patch breaks anything? What am I missing?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message t
On Wednesday 14 October 2015 14:04:00 David Daney wrote:
> On 10/14/2015 01:58 PM, Arnd Bergmann wrote:
> > On Wednesday 14 October 2015 08:47:44 David Daney wrote:
> >> On 10/14/2015 07:06 AM, Sakshi Bansal wrote:
> >>> Fixed allignment issues and line over 80 characters
> >>
> >> Use spell checki
On 10/14/2015 01:58 PM, Arnd Bergmann wrote:
On Wednesday 14 October 2015 08:47:44 David Daney wrote:
On 10/14/2015 07:06 AM, Sakshi Bansal wrote:
Fixed allignment issues and line over 80 characters
Use spell checking on 'allignment'
But that is not the main problem with the patch...
You a
On Wednesday 14 October 2015 08:47:44 David Daney wrote:
> On 10/14/2015 07:06 AM, Sakshi Bansal wrote:
> > Fixed allignment issues and line over 80 characters
>
> Use spell checking on 'allignment'
>
> But that is not the main problem with the patch...
>
>
> You are changing things other than
Hi,
On Wed, Oct 14, 2015 at 07:36:37PM +0530, Sakshi Bansal wrote:
> Fixed allignment issues and line over 80 characters
You are also doing many other things which are not mention in the
commit log.
> /*
> - printk_ratelimited("Port %d
On 10/14/2015 09:04 AM, Sakshi Bansal wrote:
Well I did not test the patch
Never send patches to code that you don't at lease attempt to compile.
since the changes were mostly coding style
related or would not affect the code.
As for the null check, if the original check is valid I can remov
On 10/14/2015 07:06 AM, Sakshi Bansal wrote:
Fixed allignment issues and line over 80 characters
Use spell checking on 'allignment'
But that is not the main problem with the patch...
You are changing things other than white space and comment formatting,
can you tell us on which platforms th
On 10/14/2015 08:51 AM, Sakshi Bansal wrote:
I am testing it on Fedora 21.
Does your Fedora 21 platform use this driver in any way? Does it even
build the driver (produce any .o files for any of the files you changed)?
No, I didn't think so.
You have to have a way to test the patch (or at
Fixed allignment issues and line over 80 characters
Signed-off-by: Sakshi Bansal
---
drivers/staging/octeon/ethernet-defines.h | 2 +-
drivers/staging/octeon/ethernet-mdio.c| 2 +-
drivers/staging/octeon/ethernet-mem.c | 4 ++--
drivers/staging/octeon/ethernet-rgmii.c | 7 +++
11 matches
Mail list logo
