Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Mark Greer
On Fri, Apr 06, 2018 at 10:52:17AM +0530, Viresh Kumar wrote: > On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer wrote: > > On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote: > >> Wrap comment to fix warning "prefer a maximum 75 chars per line" > >> > >> Signed-off-by: Gaurav Dhingra > >>

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Gaurav Dhingra
On Friday 06 April 2018 03:56 PM, Viresh Kumar wrote: On 06-04-18, 15:55, Viresh Kumar wrote: On 06-04-18, 15:47, Gaurav Dhingra wrote: I sent in an updated patchset. Though I forgot to add viresh.ku...@linaro.org to "To" in mail. That's fine, but you still haven't sent it to all the relevan

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Viresh Kumar
On 06-04-18, 15:55, Viresh Kumar wrote: > On 06-04-18, 15:47, Gaurav Dhingra wrote: > > I sent in an updated patchset. Though I forgot to add > > viresh.ku...@linaro.org to "To" in mail. > > That's fine, but you still haven't sent it to all the relevant people. > You should have used the get_maint

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Viresh Kumar
On 06-04-18, 15:47, Gaurav Dhingra wrote: > I sent in an updated patchset. Though I forgot to add > viresh.ku...@linaro.org to "To" in mail. That's fine, but you still haven't sent it to all the relevant people. You should have used the get_maintainer script (present in kernel source) for that. $

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Gaurav Dhingra
Hi, Thanks for reviewing the patch. On Friday 06 April 2018 10:52 AM, Viresh Kumar wrote: On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer wrote: On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote: Wrap comment to fix warning "prefer a maximum 75 chars per line" Signed-off-by: Gaurav

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-05 Thread Viresh Kumar
On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer wrote: > On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote: >> Wrap comment to fix warning "prefer a maximum 75 chars per line" >> >> Signed-off-by: Gaurav Dhingra >> --- >> drivers/staging/greybus/audio_codec.h | 4 +++- >> 1 file changed,

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-05 Thread Mark Greer
On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote: > Wrap comment to fix warning "prefer a maximum 75 chars per line" > > Signed-off-by: Gaurav Dhingra > --- > drivers/staging/greybus/audio_codec.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-05 Thread Greg KH
On Thu, Apr 05, 2018 at 12:47:19PM +0530, Gaurav Dhingra wrote: > Hi, > > Can anyone please review this patchset? Since this is my first patch set, so > I felt it was okay to make change even in the comment, though the patch set > fixes the warning. Please let me know in anycase your view on the p

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-05 Thread Gaurav Dhingra
Hi, Can anyone please review this patchset? Since this is my first patch set, so I felt it was okay to make change even in the comment, though the patch set fixes the warning. Please let me know in anycase your view on the patchset. On Wednesday 04 April 2018 12:02 AM, Gaurav Dhingra wrote:

[PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-03 Thread Gaurav Dhingra
Wrap comment to fix warning "prefer a maximum 75 chars per line" Signed-off-by: Gaurav Dhingra --- drivers/staging/greybus/audio_codec.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index a1d