Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

2014-04-04 Thread Dan Carpenter
On Fri, Apr 04, 2014 at 06:17:56PM +0300, Kumar Amit Mehta wrote: > On Fri, Apr 04, 2014 at 04:26:51PM +0300, Dan Carpenter wrote: > > On Fri, Apr 04, 2014 at 02:48:52PM +0300, Kumar Amit Mehta wrote: > > > On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote: > > > > On Fri, Apr 04, 2014

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

2014-04-04 Thread Joe Perches
On Fri, 2014-04-04 at 18:17 +0300, Kumar Amit Mehta wrote: > What Walter mentioned also makes sense, So shouldn't it be something > like this: I'm not Dan, but: > [amit@localhost linux-next]$ git diff > diff --git a/drivers/staging/comedi/drivers/pcl812.c > b/drivers/staging/comedi/drivers/pcl812

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

2014-04-04 Thread Kumar Amit Mehta
On Fri, Apr 04, 2014 at 04:26:51PM +0300, Dan Carpenter wrote: > On Fri, Apr 04, 2014 at 02:48:52PM +0300, Kumar Amit Mehta wrote: > > On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote: > > > On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote: > > > > Fixed a coding style

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

2014-04-04 Thread Dan Carpenter
On Fri, Apr 04, 2014 at 02:48:52PM +0300, Kumar Amit Mehta wrote: > On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote: > > On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote: > > > Fixed a coding style issue. Reported by checkpatch.pl > > > > > > > It's better if the com

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

2014-04-04 Thread walter harms
Am 04.04.2014 12:05, schrieb Kumar Amit Mehta: > Fixed a coding style issue. Reported by checkpatch.pl > > Signed-off-by: Kumar Amit Mehta > --- > drivers/staging/comedi/drivers/pcl812.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

2014-04-04 Thread Kumar Amit Mehta
On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote: > On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote: > > Fixed a coding style issue. Reported by checkpatch.pl > > > > It's better if the commit messages are more specific than this. So, should I resend the patch with

Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

2014-04-04 Thread Dan Carpenter
On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote: > Fixed a coding style issue. Reported by checkpatch.pl > It's better if the commit messages are more specific than this. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

[PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue

2014-04-04 Thread Kumar Amit Mehta
Fixed a coding style issue. Reported by checkpatch.pl Signed-off-by: Kumar Amit Mehta --- drivers/staging/comedi/drivers/pcl812.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c index 160eac8