Re: [PATCH] staging: Merge Crystal HD driver with linuxtv.org

2013-10-29 Thread Steven Newbury
On Tue, 2013-10-29 at 12:54 +, Steven Newbury wrote: > Hi Greg, > I'm making good progress. My plan is to break/clean up the patch > logically: > > patch1: Clean up debug/error messages DONE - (this has actually > resulted in some bug fixes) > <- patch1b: Clean up typedefs (missed this in m

Re: [PATCH] staging: Merge Crystal HD driver with linuxtv.org

2013-10-29 Thread Steven Newbury
Hi Greg, I'm making good progress. My plan is to break/clean up the patch logically: patch1: Clean up debug/error messages DONE - (this has actually resulted in some bug fixes) patch2: Remove commented out/unused code TODO patch3: Power management support TODO patch4: other misc fixes/chang

Re: [PATCH] staging: Merge Crystal HD driver with linuxtv.org

2013-10-27 Thread Steven Newbury
On Sun, 2013-10-27 at 09:26 -0700, Greg KH wrote: > On Sun, Oct 27, 2013 at 05:12:18PM +, Steven Newbury wrote: > > > And these patches do a lot of new work to the driver, I'd rather see it > > > get fixed up properly and moved out of staging first, before adding new > > > support to it, otherw

Re: [PATCH] staging: Merge Crystal HD driver with linuxtv.org

2013-10-27 Thread Greg KH
On Sun, Oct 27, 2013 at 05:12:18PM +, Steven Newbury wrote: > > And these patches do a lot of new work to the driver, I'd rather see it > > get fixed up properly and moved out of staging first, before adding new > > support to it, otherwise why is it in staging at all? > > That last part it a

Re: [PATCH] staging: Merge Crystal HD driver with linuxtv.org

2013-10-27 Thread Steven Newbury
On Sun, 2013-10-27 at 08:54 -0700, Greg KH wrote: > On Sun, Oct 27, 2013 at 04:27:23PM +, Steven Newbury wrote: > > The in-kernel staging version and upstream diverged in Jan 2010, > > whilst the in-kernel version has been kept up to date with kernel > > changes, both have recieved some clean u

Re: [PATCH] staging: Merge Crystal HD driver with linuxtv.org

2013-10-27 Thread Greg KH
On Sun, Oct 27, 2013 at 04:27:23PM +, Steven Newbury wrote: > The in-kernel staging version and upstream diverged in Jan 2010, > whilst the in-kernel version has been kept up to date with kernel > changes, both have recieved some clean ups and bug fixes, upstream > has also added support for ne