Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Nicholas Mc Guire
On Sun, Feb 12, 2017 at 11:01:44PM +0100, Boris Brezillon wrote: > +Mika > > On Sun, 12 Feb 2017 22:50:44 +0100 > Boris Brezillon wrote: > > > On Sun, 12 Feb 2017 17:43:31 +0100 > > Nicholas Mc Guire wrote: > > > > > writeable in struct intel_spi is a boolean and assignment should be to > > >

Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Boris Brezillon
+Mika On Sun, 12 Feb 2017 22:50:44 +0100 Boris Brezillon wrote: > On Sun, 12 Feb 2017 17:43:31 +0100 > Nicholas Mc Guire wrote: > > > writeable in struct intel_spi is a boolean and assignment should be to > > true/false not 1/0 as recommended by boolinit.cocci. > > > > Signed-off-by: Nichola

Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Boris Brezillon
On Sun, 12 Feb 2017 17:43:31 +0100 Nicholas Mc Guire wrote: > writeable in struct intel_spi is a boolean and assignment should be to > true/false not 1/0 as recommended by boolinit.cocci. > > Signed-off-by: Nicholas Mc Guire Acked-by: Boris Brezillon > --- > > make coccicheck complained wi

[PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Nicholas Mc Guire
writeable in struct intel_spi is a boolean and assignment should be to true/false not 1/0 as recommended by boolinit.cocci. Signed-off-by: Nicholas Mc Guire --- make coccicheck complained with: ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1 Patch was compile te