Re: [PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 1:55 AM Rajendra Nayak wrote: > > > On 7/9/2020 5:09 AM, Douglas Anderson wrote: > > In the patch ("spi: spi-geni-qcom: Avoid clock setting if not needed") > > we avoid a whole pile of clock code. As part of that, we should have > > restored the clock at runtime resume

Re: [PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 12:30 AM Akash Asthana wrote: > > Hi Doug, > > > > > @@ -670,7 +674,13 @@ static int __maybe_unused > > spi_geni_runtime_resume(struct device *dev) > > if (ret) > > return ret; > > > > - return geni_se_resources_on(&mas->se); > > + ret = gen

Re: [PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-09 Thread Mark Brown
On Wed, Jul 08, 2020 at 04:39:39PM -0700, Douglas Anderson wrote: > In the patch ("spi: spi-geni-qcom: Avoid clock setting if not needed") > we avoid a whole pile of clock code. As part of that, we should have > restored the clock at runtime resume. Do that. Acked-by: Mark Brown signature.asc

Re: [PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-09 Thread Rajendra Nayak
On 7/9/2020 5:09 AM, Douglas Anderson wrote: In the patch ("spi: spi-geni-qcom: Avoid clock setting if not needed") we avoid a whole pile of clock code. As part of that, we should have restored the clock at runtime resume. Do that. It turns out that, at least with today's configurations, thi

Re: [PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-09 Thread Akash Asthana
Hi Doug, @@ -670,7 +674,13 @@ static int __maybe_unused spi_geni_runtime_resume(struct device *dev) if (ret) return ret; - return geni_se_resources_on(&mas->se); + ret = geni_se_resources_on(&mas->se); + if (ret) + return ret; + + de

[PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-08 Thread Douglas Anderson
In the patch ("spi: spi-geni-qcom: Avoid clock setting if not needed") we avoid a whole pile of clock code. As part of that, we should have restored the clock at runtime resume. Do that. It turns out that, at least with today's configurations, this doesn't actually matter. That's because none o