Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-24 Thread Mika Westerberg
On Mon, Jul 24, 2017 at 04:03:31PM +0300, Andy Shevchenko wrote: > +Cc: Mika (for real this time) > > On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Avoid hogging chip select GPIOs just because they are listed for the > > master. They might be mulitplexed and, if

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-24 Thread Andy Shevchenko
+Cc: Mika (for real this time) On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Avoid hogging chip select GPIOs just because they are listed for the > master. They might be mulitplexed and, if no slave device is attached, > used for different purposes. Moreover, this str

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-24 Thread Andy Shevchenko
On Mon, Jul 24, 2017 at 2:06 PM, Jan Kiszka wrote: > On 2017-07-24 13:02, Andy Shevchenko wrote: >> On Mon, Jul 24, 2017 at 1:53 PM, Jan Kiszka wrote: >>> On 2017-07-24 12:44, Andy Shevchenko wrote: +Cc: Mika On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: > From: Jan Kiszk

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-24 Thread Jan Kiszka
On 2017-07-24 13:02, Andy Shevchenko wrote: > On Mon, Jul 24, 2017 at 1:53 PM, Jan Kiszka wrote: >> On 2017-07-24 12:44, Andy Shevchenko wrote: >>> +Cc: Mika >>> >>> On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: From: Jan Kiszka Avoid hogging chip select GPIOs just because th

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-24 Thread Andy Shevchenko
On Mon, Jul 24, 2017 at 1:53 PM, Jan Kiszka wrote: > On 2017-07-24 12:44, Andy Shevchenko wrote: >> +Cc: Mika >> >> On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Avoid hogging chip select GPIOs just because they are listed for the >>> master. They might be mulit

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-24 Thread Jan Kiszka
On 2017-07-24 12:44, Andy Shevchenko wrote: > +Cc: Mika > > On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Avoid hogging chip select GPIOs just because they are listed for the >> master. They might be mulitplexed and, if no slave device is attached, >> used for diff

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-24 Thread Andy Shevchenko
+Cc: Mika On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Avoid hogging chip select GPIOs just because they are listed for the > master. They might be mulitplexed and, if no slave device is attached, > used for different purposes. Moreover, this strategy avoids having t

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-22 Thread Andy Shevchenko
On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Avoid hogging chip select GPIOs just because they are listed for the > master. They might be mulitplexed and, if no slave device is attached, > used for different purposes. Moreover, this strategy avoids having to > allocat

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-10 Thread Jan Kiszka
On 2017-07-10 14:09, Mark Brown wrote: > On Sun, Jul 09, 2017 at 12:48:10AM +0300, Andy Shevchenko wrote: >> On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: > >>> Tested on the IOT2000 where the second SPI bus is connected to an >>> Arduino-compatible connector and multiplexed between SPI, GPI

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-10 Thread Mark Brown
On Sun, Jul 09, 2017 at 12:48:10AM +0300, Andy Shevchenko wrote: > On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: > > Tested on the IOT2000 where the second SPI bus is connected to an > > Arduino-compatible connector and multiplexed between SPI, GPIO and PWM > > usage. > Can we first switch

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-09 Thread Jan Kiszka
On 2017-07-09 11:55, Andy Shevchenko wrote: > On Sun, Jul 9, 2017 at 12:30 PM, Jan Kiszka wrote: >> On 2017-07-08 23:48, Andy Shevchenko wrote: >>> On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: From: Jan Kiszka Avoid hogging chip select GPIOs just because they are listed for

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-09 Thread Andy Shevchenko
On Sun, Jul 9, 2017 at 12:30 PM, Jan Kiszka wrote: > On 2017-07-08 23:48, Andy Shevchenko wrote: >> On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Avoid hogging chip select GPIOs just because they are listed for the >>> master. They might be mulitplexed and, if n

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-09 Thread Jan Kiszka
On 2017-07-08 23:48, Andy Shevchenko wrote: > On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Avoid hogging chip select GPIOs just because they are listed for the >> master. They might be mulitplexed and, if no slave device is attached, >> used for different purposes.

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-08 Thread Andy Shevchenko
On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Avoid hogging chip select GPIOs just because they are listed for the > master. They might be mulitplexed and, if no slave device is attached, > used for different purposes. Moreover, this strategy avoids having to > allocat

[PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

2017-07-08 Thread Jan Kiszka
From: Jan Kiszka Avoid hogging chip select GPIOs just because they are listed for the master. They might be mulitplexed and, if no slave device is attached, used for different purposes. Moreover, this strategy avoids having to allocate a cs_gpiods structure. Tested on the IOT2000 where the secon