Re: [PATCH] spi: pxa2xx: Add missed security checks

2019-10-18 Thread Andy Shevchenko
On Fri, Oct 18, 2019 at 2:37 PM Chuhong Yuan wrote: > On Fri, Oct 18, 2019 at 7:14 PM Andy Shevchenko > wrote: > > On Fri, Oct 18, 2019 at 1:39 PM Chuhong Yuan wrote: > > > On Fri, Oct 18, 2019 at 5:35 PM Andy Shevchenko > > > wrote: > > > > On Fri, Oct 18, 2019 at 8:59 AM Chuhong Yuan > > >

Re: [PATCH] spi: pxa2xx: Add missed security checks

2019-10-18 Thread Chuhong Yuan
On Fri, Oct 18, 2019 at 7:14 PM Andy Shevchenko wrote: > > On Fri, Oct 18, 2019 at 1:39 PM Chuhong Yuan wrote: > > > > On Fri, Oct 18, 2019 at 5:35 PM Andy Shevchenko > > wrote: > > > > > > On Fri, Oct 18, 2019 at 8:59 AM Chuhong Yuan wrote: > > > > > > > > pxa2xx_spi_init_pdata misses checks f

Re: [PATCH] spi: pxa2xx: Add missed security checks

2019-10-18 Thread Andy Shevchenko
On Fri, Oct 18, 2019 at 1:39 PM Chuhong Yuan wrote: > > On Fri, Oct 18, 2019 at 5:35 PM Andy Shevchenko > wrote: > > > > On Fri, Oct 18, 2019 at 8:59 AM Chuhong Yuan wrote: > > > > > > pxa2xx_spi_init_pdata misses checks for devm_clk_get and > > > platform_get_irq. > > > Add checks for them to f

Re: [PATCH] spi: pxa2xx: Add missed security checks

2019-10-18 Thread Chuhong Yuan
On Fri, Oct 18, 2019 at 5:35 PM Andy Shevchenko wrote: > > On Fri, Oct 18, 2019 at 8:59 AM Chuhong Yuan wrote: > > > > pxa2xx_spi_init_pdata misses checks for devm_clk_get and > > platform_get_irq. > > Add checks for them to fix the bugs. > > > > Signed-off-by: Chuhong Yuan > > --- > > drivers/

Re: [PATCH] spi: pxa2xx: Add missed security checks

2019-10-18 Thread Andy Shevchenko
On Fri, Oct 18, 2019 at 8:59 AM Chuhong Yuan wrote: > > pxa2xx_spi_init_pdata misses checks for devm_clk_get and > platform_get_irq. > Add checks for them to fix the bugs. > > Signed-off-by: Chuhong Yuan > --- > drivers/spi/spi-pxa2xx.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --gi

[PATCH] spi: pxa2xx: Add missed security checks

2019-10-16 Thread Chuhong Yuan
pxa2xx_spi_init_pdata misses checks for devm_clk_get and platform_get_irq. Add checks for them to fix the bugs. Signed-off-by: Chuhong Yuan --- drivers/spi/spi-pxa2xx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index bb6a14d1ab0