Re: [RESEND PATCH] spi: mediatek: fix wrong error return value on probe

2015-09-18 Thread Matthias Brugger
On Tuesday, September 15, 2015 02:46:45 PM Javier Martinez Canillas wrote: > Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") > added a new sel_clk but introduced bugs in the error paths since > the wrong struct clk pointers are passed to PTR_ERR(). > > Fixes: adcbcfea15d62 ("spi:

[RESEND PATCH] spi: mediatek: fix wrong error return value on probe

2015-09-15 Thread Javier Martinez Canillas
Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") added a new sel_clk but introduced bugs in the error paths since the wrong struct clk pointers are passed to PTR_ERR(). Fixes: adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") Signed-off-by: Javier Martinez Canillas ---

Re: [PATCH] spi: mediatek: fix wrong error return value on probe

2015-09-15 Thread Mark Brown
On Tue, Sep 15, 2015 at 01:49:11PM +0200, Javier Martinez Canillas wrote: > On 09/14/2015 08:39 PM, Mark Brown wrote: > > On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote: > >> Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") > >> added a new sel_clk but int

Re: [PATCH] spi: mediatek: fix wrong error return value on probe

2015-09-15 Thread Javier Martinez Canillas
Hello Mark, On 09/14/2015 08:39 PM, Mark Brown wrote: > On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote: >> Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") >> added a new sel_clk but introduced bugs in the error paths since >> the wrong struct clk pointer

Re: [PATCH] spi: mediatek: fix wrong error return value on probe

2015-09-14 Thread Mark Brown
On Fri, Sep 04, 2015 at 12:50:56AM +0200, Javier Martinez Canillas wrote: > Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") > added a new sel_clk but introduced bugs in the error paths since > the wrong struct clk pointers are passed to PTR_ERR(). This doesn't apply against curre

[PATCH] spi: mediatek: fix wrong error return value on probe

2015-09-03 Thread Javier Martinez Canillas
Commit adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") added a new sel_clk but introduced bugs in the error paths since the wrong struct clk pointers are passed to PTR_ERR(). Fixes: adcbcfea15d62 ("spi: mediatek: fix spi clock usage error") Signed-off-by: Javier Martinez Canillas ---