Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-16 Thread Franklin S Cooper Jr.
On 10/16/2015 09:43 AM, Mark Brown wrote: > On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote: > >> Makes sense. How about something like this? >> SPI controllers may need to be properly setup before chip selects >> can be used. Therefore, wait until the spi controller has a c

Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-16 Thread Mark Brown
On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote: > Makes sense. How about something like this? > SPI controllers may need to be properly setup before chip selects > can be used. Therefore, wait until the spi controller has a chance > to perform their setup procedure before t

Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-16 Thread Franklin S Cooper Jr.
On 10/16/2015 05:28 AM, Mark Brown wrote: > On Thu, Oct 15, 2015 at 03:51:45PM -0500, Franklin S Cooper Jr wrote: >> Some devices depend on the master controller driver setup function being >> called before calling any chipselect functions. >> >> Insure that this is done otherwise uninitialized s

Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-16 Thread Mark Brown
On Thu, Oct 15, 2015 at 03:51:45PM -0500, Franklin S Cooper Jr wrote: > Some devices depend on the master controller driver setup function being > called before calling any chipselect functions. > > Insure that this is done otherwise uninitialized structures may be > accessed causing a kernel pani

[PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-15 Thread Franklin S Cooper Jr
Some devices depend on the master controller driver setup function being called before calling any chipselect functions. Insure that this is done otherwise uninitialized structures may be accessed causing a kernel panic. Tested-by: Andy Shevchenko Signed-off-by: Franklin S Cooper Jr --- Keyston

Re: [RFC][PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-15 Thread Franklin S Cooper Jr.
On 10/14/2015 06:45 AM, Heiner Kallweit wrote: > On Wed, Oct 14, 2015 at 1:08 PM, Andy Shevchenko > wrote: >> +Cc: Jarkko to see from spi-pxa2xx prospective >> >> On Wed, Oct 14, 2015 at 12:47 PM, Ivan T. Ivanov >> wrote: >>> Adding Andy. >>> >>> On Oct 13, 2015, at 12:01 AM, Franklin S

Re: [RFC][PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-14 Thread Heiner Kallweit
On Wed, Oct 14, 2015 at 1:08 PM, Andy Shevchenko wrote: > +Cc: Jarkko to see from spi-pxa2xx prospective > > On Wed, Oct 14, 2015 at 12:47 PM, Ivan T. Ivanov wrote: >> Adding Andy. >> >> >>> On Oct 13, 2015, at 12:01 AM, Franklin S Cooper Jr wrote: >>> >>> Some devices depend on the master contr

Re: [RFC][PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-14 Thread Andy Shevchenko
+Cc: Jarkko to see from spi-pxa2xx prospective On Wed, Oct 14, 2015 at 12:47 PM, Ivan T. Ivanov wrote: > Adding Andy. > > >> On Oct 13, 2015, at 12:01 AM, Franklin S Cooper Jr wrote: >> >> Some devices depend on the master controller driver setup function being >> called before calling any chips

Re: [RFC][PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-14 Thread Ivan T. Ivanov
Adding Andy. > On Oct 13, 2015, at 12:01 AM, Franklin S Cooper Jr wrote: > > Some devices depend on the master controller driver setup function being > called before calling any chipselect functions. > > Insure that this is done otherwise uninitialized structures may be > accessed causing a ke

[RFC][PATCH] spi: Setup the master controller driver before setting the chipselect

2015-10-12 Thread Franklin S Cooper Jr
Some devices depend on the master controller driver setup function being called before calling any chipselect functions. Insure that this is done otherwise uninitialized structures may be accessed causing a kernel panic. Signed-off-by: Franklin S Cooper Jr --- drivers/spi/spi.c | 4 ++-- 1 file