Re: [PATCH] spi: Fix incomplete handling of SPI_MASTER_MUST_RX/_MUST_TX

2016-03-01 Thread Purna Chandra Mandal
Mark, On 02/08/2016 09:45 PM, Mark Brown wrote: > On Fri, Feb 05, 2016 at 10:30:24AM +0530, Purna Chandra Mandal wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier to read and reply

Re: [PATCH] spi: Fix incomplete handling of SPI_MASTER_MUST_RX/_MUST_TX

2016-02-08 Thread Mark Brown
On Fri, Feb 05, 2016 at 10:30:24AM +0530, Purna Chandra Mandal wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > Idea is good, but not sufficient. > Dummy buffers a

Re: [PATCH] spi: Fix incomplete handling of SPI_MASTER_MUST_RX/_MUST_TX

2016-02-04 Thread Purna Chandra Mandal
Thanks Mark. On 02/02/2016 04:47 AM, Mark Brown wrote: > On Mon, Feb 01, 2016 at 03:39:23PM -0700, Joshua Henderson wrote: >> From: Purna Chandra Mandal >> There is a BUG in the way SPI_MASTER_MUST_RX/TX is implemented which can >> create > Bug is a WORD like any other WORD... ack. >> (1) spi

Re: [PATCH] spi: Fix incomplete handling of SPI_MASTER_MUST_RX/_MUST_TX

2016-02-01 Thread Mark Brown
On Mon, Feb 01, 2016 at 03:39:23PM -0700, Joshua Henderson wrote: > From: Purna Chandra Mandal > There is a BUG in the way SPI_MASTER_MUST_RX/TX is implemented which can > create Bug is a WORD like any other WORD... > (1) spi core assigns dummy_rx buffer to transfer.rx_buf member and > (2) pas

[PATCH] spi: Fix incomplete handling of SPI_MASTER_MUST_RX/_MUST_TX

2016-02-01 Thread Joshua Henderson
From: Purna Chandra Mandal There is a BUG in the way SPI_MASTER_MUST_RX/TX is implemented which can create a kernel crash. To simplify design spi driver can specify *_MUST_RX during registration. In these cases spi core do allocate & assign dummy RX buffer (of right size) with the transfer if the