Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-07 Thread David Miller
From: Ethan Zhao Date: Tue, 7 Jan 2014 17:31:17 +0800 > Has kmalloc() failure checking there, so it is unnecessary to allocate with > __GFP_NOFAIL flag that might block forever. > > Signed-off-by: Ethan Zhao This allocation failing borders on catastrophic. The allocation failure handling is

[PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-07 Thread Ethan Zhao
Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever. Signed-off-by: Ethan Zhao --- arch/sparc/kernel/mdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/mdesc.c b/arch/sparc/kernel/mdesc.

Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-06 Thread David Miller
From: Ethan Zhao Date: Tue, 7 Jan 2014 10:21:51 +0800 > cc sparcli...@vger.kernel.org Please make a fresh patch posting with sparclinux included so that your patch gets properly queued up and tracked in patchwork: http://patchwork.ozlabs.org/project/sparclinux/list/ Thanks. -- To unsubscribe f

Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-06 Thread Ethan Zhao
cc sparcli...@vger.kernel.org On Wed, Dec 11, 2013 at 10:54 PM, Ethan Zhao wrote: > Has kmalloc() failure checking there, so it is unnecessary to allocate with > __GFP_NOFAIL flag that might block forever. > > Signed-off-by: Ethan Zhao > --- > arch/sparc/kernel/mdesc.c | 2 +- > 1 file changed,

Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-06 Thread Ethan Zhao
David, Got it. thanks, Ethan On Sun, Jan 5, 2014 at 10:05 AM, David Miller wrote: > From: Ethan Zhao > Date: Wed, 11 Dec 2013 22:54:21 +0800 > >> Has kmalloc() failure checking there, so it is unnecessary to allocate with >> __GFP_NOFAIL flag that might block forever. >> >> Signed-off-by: E

Re: [PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2014-01-04 Thread David Miller
From: Ethan Zhao Date: Wed, 11 Dec 2013 22:54:21 +0800 > Has kmalloc() failure checking there, so it is unnecessary to allocate with > __GFP_NOFAIL flag that might block forever. > > Signed-off-by: Ethan Zhao Please submit sparc patches with sparcli...@vger.kernel.org at least CC:'d. -- To uns

[PATCH] sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

2013-12-11 Thread Ethan Zhao
Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever. Signed-off-by: Ethan Zhao --- arch/sparc/kernel/mdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/mdesc.c b/arch/sparc/kernel/mdesc.