Re: [PATCH] sound: pci: emu10k1: Remove useless casting in emufx.c

2013-10-16 Thread Geyslan Gregório Bem
2013/10/16 Geyslan Gregório Bem : > 2013/10/16 Takashi Iwai : >> At Wed, 16 Oct 2013 13:21:45 -0300, >> Geyslan G. Bem wrote: >>> >>> Casting (void *) value returned by kcalloc is useless >>> as mentioned in Documentation/CodingStyle, Chap 14. >>> >>> Signed-off-by: Geyslan G. Bem >> >> You missed

Re: [PATCH] sound: pci: emu10k1: Remove useless casting in emufx.c

2013-10-16 Thread Geyslan Gregório Bem
2013/10/16 Takashi Iwai : > At Wed, 16 Oct 2013 13:21:45 -0300, > Geyslan G. Bem wrote: >> >> Casting (void *) value returned by kcalloc is useless >> as mentioned in Documentation/CodingStyle, Chap 14. >> >> Signed-off-by: Geyslan G. Bem > > You missed __user prefix. You can't cast user and kern

Re: [PATCH] sound: pci: emu10k1: Remove useless casting in emufx.c

2013-10-16 Thread Takashi Iwai
At Wed, 16 Oct 2013 13:21:45 -0300, Geyslan G. Bem wrote: > > Casting (void *) value returned by kcalloc is useless > as mentioned in Documentation/CodingStyle, Chap 14. > > Signed-off-by: Geyslan G. Bem You missed __user prefix. You can't cast user and kernel pointers implicitly. Takashi >

[PATCH] sound: pci: emu10k1: Remove useless casting in emufx.c

2013-10-16 Thread Geyslan G. Bem
Casting (void *) value returned by kcalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. Signed-off-by: Geyslan G. Bem --- sound/pci/emu10k1/emufx.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emu