Re: [PATCH] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-22 Thread Eliot Blennerhassett
On 23/12/14 10:41, Rickard Strandqvist wrote: > Hi Eliot! > > This is one of the largest remove patches I made. > Is it just one function you disagree with? Yes. If you generate the patch against for-next branch I guess that function will not be removed because it is used by the new code. > > T

Re: [PATCH] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-22 Thread Rickard Strandqvist
Hi Eliot! This is one of the largest remove patches I made. Is it just one function you disagree with? Then I obviously send a new Patch! Will be busy few days, but then I send a new one. Kind regards Rickard Strandqvist 2014-12-21 23:32 GMT+01:00 Eliot Blennerhassett : > On 22/12/14 05:50, Ri

Re: [PATCH] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-21 Thread Eliot Blennerhassett
On 22/12/14 05:50, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: NAK - because hpi_adapter_set_property() is now used in for-next branch of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git Otherwise I have no problem with the patch. -- To unsubscri

[PATCH] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-21 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: hpi_stream_response_to_legacy() hpi_outstream_host_buffer_free() hpi_outstream_host_buffer_get_info() hpi_outstream_host_buffer_allocate() hpi_outstream_set_time_scale() hpi_outstream_ancillary_read() hpi_outstream_ancillary_get_info() hpi_outstrea

[PATCH] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-07 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: hpi_subsys_get_version_ex() hpi_instream_wait_start() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- sound/pci/asihpi/hpi.h |4 sound/pci/asihpi/hpifunc.c |