Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source

2012-11-28 Thread Mark Brown
On Wed, Nov 28, 2012 at 10:14:28AM +, Oskar Schirmer wrote: You've somehow decided to CC half the world but still haven't managed to CC the maintainers like Liam asked (and as is covered in SubmittingPatches)... > According to documentation bit 3:2 in register SSS_CTRL are > reserved and zero

[PATCH] sound/sgtl5000: fix initial setting for DAC data source

2012-11-28 Thread Oskar Schirmer
According to documentation bit 3:2 in register SSS_CTRL are reserved and zero, so the setting of 0x0008 does not make much sense. Instead, bit 4 should be set as is with power up, to reflect routing of I2S_IN to DAC correctly. Looks much like an off by one error. Signed-off-by: Oskar Schirmer --

[PATCH] sound/sgtl5000: fix initial setting for DAC data source

2012-11-28 Thread Oskar Schirmer
According to documentation bit 3:2 in register SSS_CTRL are reserved and zero, so the setting of 0x0008 does not make much sense. Instead, bit 4 should be set as is with power up, to reflect routing of I2S_IN to DAC correctly. Looks much like an off by one error. Signed-off-by: Oskar Schirmer --

Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source

2012-11-28 Thread Liam Girdwood
On 28/11/12 09:20, Oskar Schirmer wrote: According to documentation bit 3:2 in register SSS_CTRL are reserved and zero, so the setting of 0x0008 does not make much sense. Instead, bit 4 should be set as is with power up, to reflect routing of I2S_IN to DAC correctly. Looks much like an off by on