Re: [PATCH] sound/pci/hda: depends on instead of select for INPUT

2018-01-15 Thread Takashi Iwai
On Mon, 15 Jan 2018 19:47:26 +0100, Randy Dunlap wrote: > > On 01/15/18 01:50, Takashi Iwai wrote: > > On Mon, 15 Jan 2018 08:50:17 +0100, > > Takashi Iwai wrote: > >> > >> On Mon, 15 Jan 2018 06:11:56 +0100, > >> Randy Dunlap wrote: > >>> > >>> From: Randy Dunlap > >>> > >>> Drivers should not '

Re: [PATCH] sound/pci/hda: depends on instead of select for INPUT

2018-01-15 Thread Randy Dunlap
On 01/15/18 01:50, Takashi Iwai wrote: > On Mon, 15 Jan 2018 08:50:17 +0100, > Takashi Iwai wrote: >> >> On Mon, 15 Jan 2018 06:11:56 +0100, >> Randy Dunlap wrote: >>> >>> From: Randy Dunlap >>> >>> Drivers should not 'select' a subsystem. Instead they should depend >>> on it. If the subsystem is

Re: [PATCH] sound/pci/hda: depends on instead of select for INPUT

2018-01-15 Thread Takashi Iwai
On Mon, 15 Jan 2018 08:50:17 +0100, Takashi Iwai wrote: > > On Mon, 15 Jan 2018 06:11:56 +0100, > Randy Dunlap wrote: > > > > From: Randy Dunlap > > > > Drivers should not 'select' a subsystem. Instead they should depend > > on it. If the subsystem is disabled, the user probably did that for >

Re: [PATCH] sound/pci/hda: depends on instead of select for INPUT

2018-01-14 Thread Takashi Iwai
On Mon, 15 Jan 2018 06:11:56 +0100, Randy Dunlap wrote: > > From: Randy Dunlap > > Drivers should not 'select' a subsystem. Instead they should depend > on it. If the subsystem is disabled, the user probably did that for > a purpose and one driver shouldn't be changing that. > > This also makes

[PATCH] sound/pci/hda: depends on instead of select for INPUT

2018-01-14 Thread Randy Dunlap
From: Randy Dunlap Drivers should not 'select' a subsystem. Instead they should depend on it. If the subsystem is disabled, the user probably did that for a purpose and one driver shouldn't be changing that. This also makes all sound/ drivers consistent w.r.t depending on INPUT instead of select