Re: [PATCH] sound/oss: use current->state helpers

2015-01-15 Thread Takashi Iwai
At Thu, 15 Jan 2015 00:17:25 -0800, Davidlohr Bueso wrote: > > On Thu, 2015-01-15 at 09:11 +0100, Takashi Iwai wrote: > > Well, it's a bit unusual. Why do they need to differ? Is the author > > another Davidlohr? :) If this form is preferred, I'm willing to > > apply, but I just wonder... > >

Re: [PATCH] sound/oss: use current->state helpers

2015-01-15 Thread Davidlohr Bueso
On Thu, 2015-01-15 at 09:11 +0100, Takashi Iwai wrote: > Well, it's a bit unusual. Why do they need to differ? Is the author > another Davidlohr? :) If this form is preferred, I'm willing to > apply, but I just wonder... Personal taste, really. Yes I'd prefer you apply as is. Thanks, Davidlohr

Re: [PATCH] sound/oss: use current->state helpers

2015-01-15 Thread Takashi Iwai
At Wed, 14 Jan 2015 23:51:30 -0800, Davidlohr Bueso wrote: > > On Thu, 2015-01-15 at 08:33 +0100, Takashi Iwai wrote: > > At Wed, 14 Jan 2015 23:11:43 -0800, > > Davidlohr Bueso wrote: > > > > > > From: Davidlohr Bueso > > > > > > Call __set_current_state() instead of assigning the new state di

Re: [PATCH] sound/oss: use current->state helpers

2015-01-14 Thread Davidlohr Bueso
On Thu, 2015-01-15 at 08:33 +0100, Takashi Iwai wrote: > At Wed, 14 Jan 2015 23:11:43 -0800, > Davidlohr Bueso wrote: > > > > From: Davidlohr Bueso > > > > Call __set_current_state() instead of assigning the new state directly. > > These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments

Re: [PATCH] sound/oss: use current->state helpers

2015-01-14 Thread Takashi Iwai
At Wed, 14 Jan 2015 23:11:43 -0800, Davidlohr Bueso wrote: > > From: Davidlohr Bueso > > Call __set_current_state() instead of assigning the new state directly. > These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping > track of who changed the state. > > Signed-off-by: David

[PATCH] sound/oss: use current->state helpers

2015-01-14 Thread Davidlohr Bueso
From: Davidlohr Bueso Call __set_current_state() instead of assigning the new state directly. These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping track of who changed the state. Signed-off-by: Davidlohr Bueso --- sound/oss/msnd_pinnacle.c | 4 ++-- sound/oss/swarm_cs4297a