Re: [PATCH] software_node: Add kernel-doc comments to exported symbols

2021-01-07 Thread Daniel Scally
Hi Heikki On 07/01/2021 14:19, Heikki Krogerus wrote: > On Tue, Jan 05, 2021 at 03:39:42PM +, Daniel Scally wrote: >> Hi Andy >> >> On 05/01/2021 14:53, Andy Shevchenko wrote: >>> On Mon, Jan 04, 2021 at 11:47:36PM +, Daniel Scally wrote: A number of functions which are exported via E

Re: [PATCH] software_node: Add kernel-doc comments to exported symbols

2021-01-07 Thread Heikki Krogerus
On Tue, Jan 05, 2021 at 03:39:42PM +, Daniel Scally wrote: > Hi Andy > > On 05/01/2021 14:53, Andy Shevchenko wrote: > > On Mon, Jan 04, 2021 at 11:47:36PM +, Daniel Scally wrote: > >> A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any > >> kernel-doc comments; add t

Re: [PATCH] software_node: Add kernel-doc comments to exported symbols

2021-01-05 Thread Daniel Scally
Hi Andy On 05/01/2021 14:53, Andy Shevchenko wrote: > On Mon, Jan 04, 2021 at 11:47:36PM +, Daniel Scally wrote: >> A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any >> kernel-doc comments; add those in so all exported symbols are documented. > Thanks, it's helpful! > R

Re: [PATCH] software_node: Add kernel-doc comments to exported symbols

2021-01-05 Thread Andy Shevchenko
On Mon, Jan 04, 2021 at 11:47:36PM +, Daniel Scally wrote: > A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any > kernel-doc comments; add those in so all exported symbols are documented. Thanks, it's helpful! Reviewed-by: Andy Shevchenko after addressing few nitpicks

[PATCH] software_node: Add kernel-doc comments to exported symbols

2021-01-04 Thread Daniel Scally
A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any kernel-doc comments; add those in so all exported symbols are documented. Signed-off-by: Daniel Scally --- With a view to maybe writing some documentation once the fwnode_graph_*() functions are also added. drivers/base/s