Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-30 Thread Bjorn Andersson
On Fri 18 Jan 09:39 PST 2019, Stephen Boyd wrote: > Quoting Rajendra Nayak (2019-01-17 20:48:01) > > drivers/soc/qcom/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index a5d5167c3f16..1ee298f6bf17 10

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-23 Thread Viresh Kumar
On 23-01-19, 06:22, Guenter Roeck wrote: > See Documentation/kobject.txt. > > "One important point cannot be overstated: every kobject must have a > release() method, and the kobject must persist (in a consistent state) > until that method is called. If these constraints are not met, the code is >

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-23 Thread Guenter Roeck
On 1/23/19 3:16 AM, Viresh Kumar wrote: On 22-01-19, 16:05, Rajendra Nayak wrote: Seeing this now during remove [ 34.008216] [ cut here ] [ 34.012894] Device 'mss' does not have a release() function, it is broken and must be fixed. See Docum. [ 34.024143] WARNING:

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-23 Thread Viresh Kumar
On 22-01-19, 16:05, Rajendra Nayak wrote: > Seeing this now during remove > > [ 34.008216] [ cut here ] > [ 34.012894] Device 'mss' does not have a release() function, it is broken > and must be fixed. See Docum. > [ 34.024143] WARNING: CPU: 6 PID: 1600 at drivers/ba

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-22 Thread Rajendra Nayak
On 1/22/2019 3:38 PM, Viresh Kumar wrote: On 22-01-19, 15:24, Rajendra Nayak wrote: I was doing some quick testing by adding the calls to of_genpd_remove_last() as suggested by Ulf for cleaning up the genpd registrations, and I run into this backtrace when the driver re-probes followed by a re

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-22 Thread Viresh Kumar
On 22-01-19, 15:24, Rajendra Nayak wrote: > I was doing some quick testing by adding the calls to of_genpd_remove_last() > as > suggested by Ulf for cleaning up the genpd registrations, and I run into this > backtrace when the driver re-probes followed by a remove > > [ 59.204525] kobject ((___

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-22 Thread Rajendra Nayak
Adding Viresh and Ulf to this thread, On 1/22/2019 10:38 AM, Guenter Roeck wrote: On 1/21/19 6:30 PM, Rajendra Nayak wrote: On 1/18/2019 11:09 PM, Stephen Boyd wrote: Quoting Rajendra Nayak (2019-01-17 20:48:01)   drivers/soc/qcom/Kconfig | 2 +-   1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-21 Thread Guenter Roeck
On 1/21/19 6:30 PM, Rajendra Nayak wrote: On 1/18/2019 11:09 PM, Stephen Boyd wrote: Quoting Rajendra Nayak (2019-01-17 20:48:01)   drivers/soc/qcom/Kconfig | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index a5d5167c3

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-21 Thread Rajendra Nayak
On 1/18/2019 11:09 PM, Stephen Boyd wrote: Quoting Rajendra Nayak (2019-01-17 20:48:01) drivers/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index a5d5167c3f16..1ee298f6bf17 100644 --- a/drivers/soc

Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-18 Thread Stephen Boyd
Quoting Rajendra Nayak (2019-01-17 20:48:01) > drivers/soc/qcom/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index a5d5167c3f16..1ee298f6bf17 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/

[PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

2019-01-17 Thread Rajendra Nayak
Since QCOM_RPMPD is bool and it depends on QCOM_SMD_RPM which is tristate, configurations such as arm64:allmodconfig result in CONFIG_QCOM_RPMPD=y CONFIG_QCOM_SMD_RPM=m This in turn results in drivers/soc/qcom/rpmpd.o: In function `rpmpd_send_corner': rpmpd.c:(.text+0x10c): undefined reference t