Re: [PATCH] soc/tegra: Fix terminating condition

2018-11-22 Thread Frank Lee
Hi Thierry: How about change it to this? while (*match->compatible) { This is more beautiful.:-) Thanks, Yangtao On Thu, Nov 22, 2018 at 4:50 PM Thierry Reding wrote: > > On Thu, Nov 22, 2018 at 12:52:44AM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/soc/tegra

Re: [PATCH] soc/tegra: Fix terminating condition

2018-11-22 Thread Thierry Reding
On Thu, Nov 22, 2018 at 12:52:44AM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/soc/tegra/common.c:27:16: error: address of array > 'match->compatible' will always evaluate to 'true' > [-Werror,-Wpointer-bool-conversion] > while (match->compatible) { > ~ ~~~^

Re: [PATCH] soc/tegra: Fix terminating condition

2018-11-22 Thread Frank Lee
On Thu, Nov 22, 2018 at 3:53 PM Nathan Chancellor wrote: > > Clang warns: > > drivers/soc/tegra/common.c:27:16: error: address of array > 'match->compatible' will always evaluate to 'true' > [-Werror,-Wpointer-bool-conversion] > while (match->compatible) { > ~ ~~~^

[PATCH] soc/tegra: Fix terminating condition

2018-11-21 Thread Nathan Chancellor
Clang warns: drivers/soc/tegra/common.c:27:16: error: address of array 'match->compatible' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] while (match->compatible) { ~ ~~~^~ 1 error generated. Whoops, we have an infinite loop and QEMU no longer