Re: [PATCH] soc/meson: add missing free_irq() in error path

2020-06-09 Thread Mark Brown
On Sat, 6 Jun 2020 17:31:03 +0200, Pavel Machek wrote: > free_irq() is missing in case of error, fix that. > > Signed-off-by: Pavel Machek (CIP) > > diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c > index 2e9b56b29d31..b2e867113226 100644 > --- a/sound/soc/meson/axg-fifo.c >

Re: [PATCH] soc/meson: add missing free_irq() in error path

2020-06-08 Thread Mark Brown
On Sat, Jun 06, 2020 at 05:31:03PM +0200, Pavel Machek wrote: > free_irq() is missing in case of error, fix that. > > Signed-off-by: Pavel Machek (CIP) > > diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c In addition to the subject line issue your Signed-off-by does not matc

Re: [PATCH] soc/meson: add missing free_irq() in error path

2020-06-08 Thread Mark Brown
On Sat, Jun 06, 2020 at 05:31:03PM +0200, Pavel Machek wrote: > free_irq() is missing in case of error, fix that. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the are

Re: [PATCH] soc/meson: add missing free_irq() in error path

2020-06-07 Thread Jerome Brunet
On Sat 06 Jun 2020 at 17:31, Pavel Machek wrote: > free_irq() is missing in case of error, fix that. > > Signed-off-by: Pavel Machek (CIP) Reviewed-by: Jerome Brunet > > diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c > index 2e9b56b29d31..b2e867113226 100644 > --- a/so

[PATCH] soc/meson: add missing free_irq() in error path

2020-06-06 Thread Pavel Machek
free_irq() is missing in case of error, fix that. Signed-off-by: Pavel Machek (CIP) diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c index 2e9b56b29d31..b2e867113226 100644 --- a/sound/soc/meson/axg-fifo.c +++ b/sound/soc/meson/axg-fifo.c @@ -249,7 +249,7 @@ int axg_fifo_pcm_