Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-27 Thread Russell King - ARM Linux
On Sat, Aug 27, 2016 at 05:30:42PM +0200, Robert Jarzmik wrote: > Hi Russell, > > With your patch : > - lubbock, mainstone and zylonite boards are working correctly >=> ie. all my boards are working correctly > > - the message "ifconfig: SIOCSIFHWADDR: Device or resource busy" is still > t

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-27 Thread Robert Jarzmik
Russell King - ARM Linux writes: > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: >> Arnd Bergmann writes: >> >> > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> >> drivers/net/ethernet/smsc/smc91x.h | 50 >> >> +++--- >> >

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-26 Thread Russell King - ARM Linux
On Fri, Aug 26, 2016 at 12:38:48PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 26, 2016 at 11:41:21AM +0200, Arnd Bergmann wrote: > > On Thursday, August 25, 2016 11:37:43 PM CEST Russell King - ARM Linux > > wrote: > > > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: > >

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-26 Thread Russell King - ARM Linux
On Fri, Aug 26, 2016 at 11:41:21AM +0200, Arnd Bergmann wrote: > On Thursday, August 25, 2016 11:37:43 PM CEST Russell King - ARM Linux wrote: > > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: > > > Arnd Bergmann writes: > > /* > > + * Any 16-bit access is performed with two 8-b

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-26 Thread Arnd Bergmann
On Friday, August 26, 2016 11:41:21 AM CEST Arnd Bergmann wrote: > > I think this breaks machines that declare a device that just lists > SMC91X_USE_32BIT but not SMC91X_USE_16BIT. Right now, the way this > is interpreted is to use 32-bit accessors for most things, but > not avoiding 16-bit reads.

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-26 Thread Arnd Bergmann
On Thursday, August 25, 2016 11:37:43 PM CEST Russell King - ARM Linux wrote: > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: > > Arnd Bergmann writes: > /* > + * Any 16-bit access is performed with two 8-bit accesses if the hardware > + * can't do it directly. Most registers ar

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-25 Thread Russell King - ARM Linux
On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: > Arnd Bergmann writes: > > > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: > >> drivers/net/ethernet/smsc/smc91x.h | 50 > >> +++--- > >> 1 file changed, 30 insertions(+), 20 del

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-25 Thread Robert Jarzmik
Arnd Bergmann writes: > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> drivers/net/ethernet/smsc/smc91x.h | 50 >> +++--- >> 1 file changed, 30 insertions(+), 20 deletions(-) >> >> While this patch fixes one bug on Neponset, it probably doe

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-25 Thread Arnd Bergmann
On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: > drivers/net/ethernet/smsc/smc91x.h | 50 > +++--- > 1 file changed, 30 insertions(+), 20 deletions(-) > > While this patch fixes one bug on Neponset, it probably doesn't address > the one that Rus

[PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-25 Thread Arnd Bergmann
The ARM specific I/O operations are almost the same as the generic ones, with the exception of the SMC_outw macro that works around a problem of some platforms that cannot write to 16-bit registers at an address that is not 32-bit aligned. By inspection, I found that this is handled already in the